simplifying ng:click spec

IgorMinar · mhevery · commit bbd87c9425ae · 2010-10-23T14:22:54.000-07:00
diff --git a/src/directives.js b/src/directives.js
@@ -205,7 +205,7 @@ angularWidget("@ng:repeat", function(expression, element){
  *
  * Events that are handled via these handler are always configured not to propagate further.
  *
- * TODO: maybe we should consider allowing users to control even propagation in the future.
+ * TODO: maybe we should consider allowing users to control event propagation in the future.
  */
 angularDirective("ng:click", function(expression, element){
   return function(element){
diff --git a/test/directivesSpec.js b/test/directivesSpec.js
@@ -172,7 +172,7 @@ describe("directives", function(){
   });
 
   describe('ng:click', function(){
-    it('should fire event', function(){
+    it('should get called on a click', function(){
       var scope = compile('<div ng:click="clicked = true"></div>');
       scope.$eval();
       expect(scope.$get('clicked')).toBeFalsy();
@@ -184,14 +184,14 @@ describe("directives", function(){
     it('should stop event propagation', function() {
       var scope = compile('<div ng:click="outer = true"><div ng:click="inner = true"></div></div>');
       scope.$eval();
-      expect(scope.$get('outer')).not.toBeDefined();
-      expect(scope.$get('inner')).not.toBeDefined();
+      expect(scope.outer).not.toBeDefined();
+      expect(scope.inner).not.toBeDefined();
 
-      var innerDiv = jqLite(element.children()[0]);
+      var innerDiv = element.children()[0];
 
       browserTrigger(innerDiv, 'click');
-      expect(scope.$get('outer')).not.toBeDefined();
-      expect(scope.$get('inner')).toEqual(true);
+      expect(scope.outer).not.toBeDefined();
+      expect(scope.inner).toEqual(true);
     });
   });
 

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ angularWidget("@ng:repeat", function(expression, element){`
`205`	`205`	`*`
`206`	`206`	`* Events that are handled via these handler are always configured not to propagate further.`
`207`	`207`	`*`
`208`		`- * TODO: maybe we should consider allowing users to control even propagation in the future.`
	`208`	`+ * TODO: maybe we should consider allowing users to control event propagation in the future.`
`209`	`209`	`*/`
`210`	`210`	`angularDirective("ng:click", function(expression, element){`
`211`	`211`	`return function(element){`