fix(resource): Update RegExp to allow urlParams with out leading slash

Fredrik Bonander · mhevery · commit b7e1fb051579 · 2013-02-14T14:43:55.000-08:00
Will allow reoucese to be loaded from a relative path
Example:
var R = $resource(':path');
R.get({ path : 'data.json' });

Example usage:
Load resources in applications not using webserver, ie local webapp in 
on a tablet.
diff --git a/src/ngResource/resource.js b/src/ngResource/resource.js
@@ -308,7 +308,7 @@ angular.module('ngResource', ['ng']).
       this.defaults = defaults || {};
       var urlParams = this.urlParams = {};
       forEach(template.split(/\W/), function(param){
-        if (param && template.match(new RegExp("[^\\\\]:" + param + "\\W"))) {
+        if (param && (new RegExp("(^|[^\\\\]):" + param + "\\W").test(template))) {
           urlParams[param] = true;
         }
       });
diff --git a/test/ngResource/resourceSpec.js b/test/ngResource/resourceSpec.js
@@ -129,6 +129,18 @@ describe("resource", function() {
     R.get({a: 'doh@fo o', ':bar': '$baz@1', '!do&h': 'g=a h'});
   });
 
+  it('should allow relative paths in resource url', function () {
+    var R = $resource(':relativePath');
+    $httpBackend.expect('GET', 'data.json').respond('{}');
+    R.get({ relativePath: 'data.json' });
+  });
+
+  it('should handle + in url params', function () {
+    var R = $resource('/api/myapp/:myresource?from=:from&to=:to&histlen=:histlen');
+    $httpBackend.expect('GET', '/api/myapp/pear+apple?from=2012-04-01&to=2012-04-29&histlen=3').respond('{}');
+    R.get({ myresource: 'pear+apple', from : '2012-04-01', to : '2012-04-29', histlen : 3  });
+  });
+
 
   it('should encode & in url params', function() {
     var R = $resource('/Path/:a');

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ angular.module('ngResource', ['ng']).`
`308`	`308`	`this.defaults = defaults \|\| {};`
`309`	`309`	`var urlParams = this.urlParams = {};`
`310`	`310`	`forEach(template.split(/\W/), function(param){`
`311`		`- if (param && template.match(new RegExp("[^\\\\]:" + param + "\\W"))) {`
	`311`	`+ if (param && (new RegExp("(^\|[^\\\\]):" + param + "\\W").test(template))) {`
`312`	`312`	`urlParams[param] = true;`
`313`	`313`	`}`
`314`	`314`	`});`