fix($sniffer): ensure older versions of webkit work for animations

matsko · mhevery · commit b1a43cd04e87 · 2013-08-19T15:51:28.000-07:00
diff --git a/src/ng/sniffer.js b/src/ng/sniffer.js
@@ -35,6 +35,11 @@ function $SnifferProvider() {
           break;
         }
       }
+
+      if(!vendorPrefix) {
+        vendorPrefix = ('WebkitOpacity' in bodyStyle) && 'webkit';
+      }
+
       transitions = !!(('transition' in bodyStyle) || (vendorPrefix + 'Transition' in bodyStyle));
       animations  = !!(('animation' in bodyStyle) || (vendorPrefix + 'Animation' in bodyStyle));
       
diff --git a/test/ng/snifferSpec.js b/test/ng/snifferSpec.js
@@ -122,6 +122,22 @@ describe('$sniffer', function() {
       });
     });
 
+    it('should still work for an older version of Webkit', function() {
+      module(function($provide) {
+        var doc = {
+          body : {
+            style : {
+              WebkitOpacity: '0'
+            }
+          }
+        };
+        $provide.value('$document', jqLite(doc));
+      });
+      inject(function($sniffer) {
+        expect($sniffer.vendorPrefix).toBe('webkit');
+      });
+    });
+
   });
 
   describe('animations', function() {
@@ -201,6 +217,23 @@ describe('$sniffer', function() {
         expect($sniffer.animations).toBe(true);
       });
     });
+
+    it('should be true when an older version of Webkit is used', function() {
+      module(function($provide) {
+        var doc = {
+          body : {
+            style : {
+              WebkitOpacity: '0'
+            }
+          }
+        };
+        $provide.value('$document', jqLite(doc));
+      });
+      inject(function($sniffer) {
+        expect($sniffer.animations).toBe(false);
+      });
+    });
+
   });
 
   describe('transitions', function() {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,11 @@ function $SnifferProvider() {`
`35`	`35`	`break;`
`36`	`36`	`}`
`37`	`37`	`}`
	`38`	`+`
	`39`	`+ if(!vendorPrefix) {`
	`40`	`+ vendorPrefix = ('WebkitOpacity' in bodyStyle) && 'webkit';`
	`41`	`+ }`
	`42`	`+`
`38`	`43`	`transitions = !!(('transition' in bodyStyle) \|\| (vendorPrefix + 'Transition' in bodyStyle));`
`39`	`44`	`animations = !!(('animation' in bodyStyle) \|\| (vendorPrefix + 'Animation' in bodyStyle));`
`40`	`45`