fix(jqLite): fix regression where mutating the dom tree on a event breaks jqLite.remove

rodyhaddad · rodyhaddad · commit a00c9bca401a · 2014-07-30T11:13:36.000-07:00
Closes angular#8359
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -248,7 +248,7 @@ function jqLiteDealoc(element, onlyDescendants){
 
   if (element.childNodes && element.childNodes.length) {
     // we use querySelectorAll because documentFragments don't have getElementsByTagName
-    var descendants = element.getElementsByTagName ? element.getElementsByTagName('*') :
+    var descendants = element.getElementsByTagName ? sliceArgs(element.getElementsByTagName('*')) :
                     element.querySelectorAll ? element.querySelectorAll('*') : [];
     for (var i = 0, l = descendants.length; i < l; i++) {
       jqLiteRemoveData(descendants[i]);
diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js
@@ -535,6 +535,16 @@ describe('jqLite', function() {
         browserTrigger(span);
         expect(log).toEqual('click;');
       });
+
+      it('should work if the descendants of the element change while it\'s being removed', function() {
+        var div = jqLite('<div><p><span>text</span></p></div>');
+        div.find('p').on('$destroy', function() {
+          div.find('span').remove();
+        });
+        expect(function() {
+          div.remove();
+        }).not.toThrow();
+      });
     });
   });
 
