fix(loader): expose $$minErr to modules such asngResource

petebacondarwin · IgorMinar · commit 9e89a31b129e · 2013-11-21T22:51:26.000-08:00
This is highlighted in angular-phonecat when you try to use the index-async.html which needs to load the ngResource module asynchronously but fails when it tries to call `angular.$$minErr` to create the $resourceMinErr object. Closes angular#5050
diff --git a/src/loader.js b/src/loader.js
@@ -17,7 +17,12 @@ function setupModuleLoader(window) {
     return obj[name] || (obj[name] = factory());
   }
 
-  return ensure(ensure(window, 'angular', Object), 'module', function() {
+  var angular = ensure(window, 'angular', Object);
+
+  // We need to expose `angular.$$minErr` to modules such as `ngResource` that reference it during bootstrap
+  angular.$$minErr = angular.$$minErr || minErr;
+
+  return ensure(angular, 'module', function() {
     /** @type {Object.<string, angular.Module>} */
     var modules = {};
 
diff --git a/test/loaderSpec.js b/test/loaderSpec.js
@@ -78,4 +78,8 @@ describe('module loader', function() {
       window.angular.module('hasOwnProperty', []);
     }).toThrowMinErr('ng','badname', "hasOwnProperty is not a valid module name");
   });
+
+  it('should expose `$$minErr` on the `angular` object', function() {
+    expect(window.angular.$$minErr).toEqual(jasmine.any(Function));
+  })
 });
