Corrected an issue where properties inherited from __proto__ show up in ng:repeat.

mhevery · mhevery · commit 9e67da420b60 · 2011-02-25T09:23:30.000-08:00
Closses angular#112
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,9 @@
 - Change API angular.compile(..) to angular.compile(element)([scope], [cloneAttachFn])
 - remove ng:watch directives since it encourages logic in the UI.
 
+### Bug Fixes
+- Corrected an issue where properties inherited from __proto__ show up in ng:repeat.
+
 <a name="0.9.11"><a/>
 # <angular/> 0.9.11 snow-maker  (2011-02-08) #
 
diff --git a/src/widgets.js b/src/widgets.js
@@ -927,7 +927,7 @@ angularWidget('@ng:repeat', function(expression, element){
       }
 
       for (key in collection) {
-        if (!is_array || collection.hasOwnProperty(key)) {
+        if (collection.hasOwnProperty(key)) {
           if (index < childCount) {
             // reuse existing child
             childScope = children[index];
diff --git a/test/widgetsSpec.js b/test/widgetsSpec.js
@@ -727,6 +727,18 @@ describe("widget", function(){
       expect(element.text()).toEqual('misko:swe;shyam:set;');
     });
 
+    it('should not ng:repeat over parent properties', function(){
+      var Class = function(){};
+      Class.prototype.abc = function(){};
+      Class.prototype.value = 'abc';
+
+      var scope = compile('<ul><li ng:repeat="(key, value) in items" ng:bind="key + \':\' + value + \';\' "></li></ul>');
+      scope.items = new Class();
+      scope.items.name = 'value';
+      scope.$eval();
+      expect(element.text()).toEqual('name:value;');
+    });
+
     it('should error on wrong parsing of ng:repeat', function(){
       var scope = compile('<ul><li ng:repeat="i dont parse"></li></ul>');
 

Original file line number	Diff line number	Diff line change
`@@ -927,7 +927,7 @@ angularWidget('@ng:repeat', function(expression, element){`
`927`	`927`	`}`
`928`	`928`
`929`	`929`	`for (key in collection) {`
`930`		`- if (!is_array \|\| collection.hasOwnProperty(key)) {`
	`930`	`+ if (collection.hasOwnProperty(key)) {`
`931`	`931`	`if (index < childCount) {`
`932`	`932`	`// reuse existing child`
`933`	`933`	`childScope = children[index];`