chore(ngAnimate): add TODO messages indicating desire to remove hack

caitp · caitp · commit 9e4701a5ab9b · 2014-10-08T14:56:49.000-04:00
diff --git a/src/ng/animate.js b/src/ng/animate.js
@@ -289,6 +289,8 @@ var $AnimateProvider = ['$provide', function($provide) {
         element = jqLite(element);
 
         if (runSynchronously) {
+          // TODO(@caitp/@matsko): Remove undocumented `runSynchronously` parameter, and always
+          // perform DOM manipulation asynchronously or in postDigest.
           self.$$addClassImmediately(element, add);
           self.$$removeClassImmediately(element, remove);
           return asyncPromise();
diff --git a/src/ngAnimate/animate.js b/src/ngAnimate/animate.js
@@ -979,6 +979,9 @@ angular.module('ngAnimate', ['ng'])
           element = stripCommentsFromElement(element);
 
           if (classBasedAnimationsBlocked(element)) {
+            // TODO(@caitp/@matsko): Don't use private/undocumented API here --- we should not be
+            // changing the DOM synchronously in this case. The `true` parameter must eventually be
+            // removed.
             return $delegate.setClass(element, add, remove, true);
           }
 

Original file line number	Diff line number	Diff line change
`@@ -979,6 +979,9 @@ angular.module('ngAnimate', ['ng'])`
`979`	`979`	`element = stripCommentsFromElement(element);`
`980`	`980`
`981`	`981`	`if (classBasedAnimationsBlocked(element)) {`
	`982`	`+ // TODO(@caitp/@matsko): Don't use private/undocumented API here --- we should not be`
	`983`	+ // changing the DOM synchronously in this case. The `true` parameter must eventually be
	`984`	`+ // removed.`
`982`	`985`	`return $delegate.setClass(element, add, remove, true);`
`983`	`986`	`}`
`984`	`987`