fix($browser): do not decode cookies that do not appear encoded

shahata · IgorMinar · commit 9c9959059eb8 · 2014-10-09T12:34:50.000-07:00
Closes angular#9211 Closes angular#9225
diff --git a/src/ng/browser.js b/src/ng/browser.js
@@ -297,6 +297,14 @@ function Browser(window, document, $log, $sniffer) {
   var lastCookieString = '';
   var cookiePath = self.baseHref();
 
+  function safeDecodeURIComponent(str) {
+    try {
+      return decodeURIComponent(str);
+    } catch (e) {
+      return str;
+    }
+  }
+
   /**
    * @name $browser#cookies
    *
@@ -350,12 +358,12 @@ function Browser(window, document, $log, $sniffer) {
           cookie = cookieArray[i];
           index = cookie.indexOf('=');
           if (index > 0) { //ignore nameless cookies
-            name = decodeURIComponent(cookie.substring(0, index));
+            name = safeDecodeURIComponent(cookie.substring(0, index));
             // the first value that is seen for a cookie is the most
             // specific one.  values for the same cookie name that
             // follow are for less specific paths.
             if (lastCookies[name] === undefined) {
-              lastCookies[name] = decodeURIComponent(cookie.substring(index + 1));
+              lastCookies[name] = safeDecodeURIComponent(cookie.substring(index + 1));
             }
           }
         }
diff --git a/test/ng/browserSpecs.js b/test/ng/browserSpecs.js
@@ -283,7 +283,7 @@ describe('browser', function() {
         expect(oldVal).not.toBeDefined();
       });
 
-      it('should escape both name and value', function() {
+      it('should encode both name and value', function() {
         browser.cookies('cookie1=', 'val;ue');
         browser.cookies('cookie2=bar;baz', 'val=ue');
 
@@ -359,7 +359,7 @@ describe('browser', function() {
         expect(browser.cookies()['foo']).toBe('"first"');
       });
 
-      it ('should unescape cookie values that were escaped by puts', function() {
+      it ('should decode cookie values that were encoded by puts', function() {
         document.cookie = "cookie2%3Dbar%3Bbaz=val%3Due;path=/";
         expect(browser.cookies()['cookie2=bar;baz']).toEqual('val=ue');
       });
@@ -371,10 +371,16 @@ describe('browser', function() {
         expect(browser.cookies()['cookie name']).not.toBeDefined();
       });
 
-      it('should unscape special characters in cookie values', function() {
+      it('should decode special characters in cookie values', function() {
         document.cookie = 'cookie_name=cookie_value_%E2%82%AC';
         expect(browser.cookies()['cookie_name']).toEqual('cookie_value_€');
       });
+
+      it('should not decode cookie values that do not appear to be encoded', function() {
+        // see #9211 - sometimes cookies contain a value that causes decodeURIComponent to throw
+        document.cookie = 'cookie_name=cookie_value_%XX';
+        expect(browser.cookies()['cookie_name']).toEqual('cookie_value_%XX');
+      });
     });
 
 
