style: enable jscs requireLeftStickedOperators rule

TimotheeJeannin · btford · commit 8c7b9b8de432 · 2014-03-07T15:05:22.000-08:00
Closed angular#6544.
diff --git a/.jscs.json b/.jscs.json
@@ -1,5 +1,6 @@
 {
   "disallowKeywords": ["with"],
   "disallowTrailingWhitespace": true,
-  "requireRightStickedOperators": ["!"]
+  "requireRightStickedOperators": ["!"],
+  "requireLeftStickedOperators": [","]
 }
diff --git a/.jscs.json.todo b/.jscs.json.todo
@@ -8,7 +8,6 @@
   "requireSpaceAfterKeywords": ["if", "else", "for", "while", "do", "switch", "return", "try", "catch"],
   "disallowLeftStickedOperators": ["?", "+", "-", "/", "*", "=", "==", "===", "!=", "!==", ">", ">=", "<", "<="],
   "disallowRightStickedOperators": ["?", "+", "/", "*", ":", "=", "==", "===", "!=", "!==", ">", ">=", "<", "<="],
-  "requireLeftStickedOperators": [","],
   "disallowImplicitTypeConversion": ["string"],
   "disallowMultipleLineBreaks": true,
   "disallowKeywordsOnNewLine": ["else"],
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -457,7 +457,7 @@ forEach({
     return jqLite(element).data('$isolateScope') || jqLite(element).data('$isolateScopeNoTemplate');
   },
 
-  controller: jqLiteController ,
+  controller: jqLiteController,
 
   injector: function(element) {
     return jqLiteInheritedData(element, '$injector');
diff --git a/src/ngSanitize/sanitize.js b/src/ngSanitize/sanitize.js
@@ -254,7 +254,7 @@ function htmlParser( html, handler ) {
         match = html.match( DOCTYPE_REGEXP );
 
         if ( match ) {
-          html = html.replace( match[0] , '');
+          html = html.replace( match[0], '');
           chars = false;
         }
       // end tag
diff --git a/test/auto/injectorSpec.js b/test/auto/injectorSpec.js
@@ -163,7 +163,7 @@ describe('injector', function() {
       function $f_n0 /*
           */(
           $a, // x, <-- looks like an arg but it is a comment
-          b_ , /* z, <-- looks like an arg but it is a
+          b_, /* z, <-- looks like an arg but it is a
                  multi-line comment
                  function (a, b) {}
                  */
diff --git a/test/ng/sceSpecs.js b/test/ng/sceSpecs.js
@@ -109,7 +109,7 @@ describe('SCE', function() {
     }));
 
     it('should NOT wrap unknown contexts', inject(function($sce) {
-      expect(function() { $sce.trustAs('unknown1' , '123'); }).toThrowMinErr(
+      expect(function() { $sce.trustAs('unknown1', '123'); }).toThrowMinErr(
           '$sce', 'icontext', 'Attempted to trust a value in invalid context. Context: unknown1; Value: 123');
     }));
 
diff --git a/test/ngTouch/directive/ngSwipeSpec.js b/test/ngTouch/directive/ngSwipeSpec.js
@@ -222,6 +222,6 @@ var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent,
   });
 }
 
-swipeTests('touch', true  /* restrictBrowers */, 'touchstart', 'touchmove', 'touchend');
-swipeTests('mouse', false /* restrictBrowers */, 'mousedown',  'mousemove', 'mouseup');
+swipeTests('touch', /* restrictBrowers */ true, 'touchstart', 'touchmove', 'touchend');
+swipeTests('mouse', /* restrictBrowers */ false, 'mousedown',  'mousemove', 'mouseup');
 
diff --git a/test/ngTouch/swipeSpec.js b/test/ngTouch/swipeSpec.js
@@ -387,6 +387,6 @@ var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent,
   });
 }
 
-swipeTests('touch', true  /* restrictBrowers */, 'touchstart', 'touchmove', 'touchend');
-swipeTests('mouse', false /* restrictBrowers */, 'mousedown',  'mousemove', 'mouseup');
+swipeTests('touch', /* restrictBrowers */ true, 'touchstart', 'touchmove', 'touchend');
+swipeTests('mouse', /* restrictBrowers */ false, 'mousedown',  'mousemove', 'mouseup');
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"disallowKeywords": ["with"],`
`3`	`3`	`"disallowTrailingWhitespace": true,`
`4`		`- "requireRightStickedOperators": ["!"]`
	`4`	`+ "requireRightStickedOperators": ["!"],`
	`5`	`+ "requireLeftStickedOperators": [","]`
`5`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ function htmlParser( html, handler ) {`
`254`	`254`	`match = html.match( DOCTYPE_REGEXP );`
`255`	`255`
`256`	`256`	`if ( match ) {`
`257`		`- html = html.replace( match[0] , '');`
	`257`	`+ html = html.replace( match[0], '');`
`258`	`258`	`chars = false;`
`259`	`259`	`}`
`260`	`260`	`// end tag`
Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,6 @@ var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent,`
`222`	`222`	`});`
`223`	`223`	`}`
`224`	`224`
`225`		`-swipeTests('touch', true /* restrictBrowers */, 'touchstart', 'touchmove', 'touchend');`
`226`		`-swipeTests('mouse', false /* restrictBrowers */, 'mousedown', 'mousemove', 'mouseup');`
	`225`	`+swipeTests('touch', /* restrictBrowers */ true, 'touchstart', 'touchmove', 'touchend');`
	`226`	`+swipeTests('mouse', /* restrictBrowers */ false, 'mousedown', 'mousemove', 'mouseup');`
`227`	`227`
Original file line number	Diff line number	Diff line change
`@@ -387,6 +387,6 @@ var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent,`
`387`	`387`	`});`
`388`	`388`	`}`
`389`	`389`
`390`		`-swipeTests('touch', true /* restrictBrowers */, 'touchstart', 'touchmove', 'touchend');`
`391`		`-swipeTests('mouse', false /* restrictBrowers */, 'mousedown', 'mousemove', 'mouseup');`
	`390`	`+swipeTests('touch', /* restrictBrowers */ true, 'touchstart', 'touchmove', 'touchend');`
	`391`	`+swipeTests('mouse', /* restrictBrowers */ false, 'mousedown', 'mousemove', 'mouseup');`
`392`	`392`