fix($parse): assign returns the new value

lgalfaso · lgalfaso · commit 7d2c6eeef8ad · 2015-08-31T22:40:23.000+02:00
The `.assign` function returns the new value. The version with csp enabled already has this behavior. Closes angular#12675 Closes angular#12708
diff --git a/src/ng/parse.js b/src/ng/parse.js
@@ -774,6 +774,7 @@ ASTCompiler.prototype = {
       this.state.computing = 'assign';
       var result = this.nextId();
       this.recurse(assignable, result);
+      this.return_(result);
       extra = 'fn.assign=' + this.generateFunction('assign', 's,v,l');
     }
     var toWatch = getInputs(ast.body);
diff --git a/test/ng/parseSpec.js b/test/ng/parseSpec.js
@@ -2797,6 +2797,14 @@ describe('parser', function() {
           expect(scope).toEqual({a:123});
         }));
 
+        it('should return the assigned value', inject(function($parse) {
+          var fn = $parse('a');
+          var scope = {};
+          expect(fn.assign(scope, 123)).toBe(123);
+          var someObject = {};
+          expect(fn.assign(scope, someObject)).toBe(someObject);
+        }));
+
         it('should expose working assignment function for expressions ending with brackets', inject(function($parse) {
           var fn = $parse('a.b["c"]');
           expect(fn.assign).toBeTruthy();

Original file line number	Diff line number	Diff line change
`@@ -774,6 +774,7 @@ ASTCompiler.prototype = {`
`774`	`774`	`this.state.computing = 'assign';`
`775`	`775`	`var result = this.nextId();`
`776`	`776`	`this.recurse(assignable, result);`
	`777`	`+ this.return_(result);`
`777`	`778`	`extra = 'fn.assign=' + this.generateFunction('assign', 's,v,l');`
`778`	`779`	`}`
`779`	`780`	`var toWatch = getInputs(ast.body);`