fix(jqLite): clone wrapNode in jqlite/wrap

cqr · IgorMinar · commit 77d3e7544642 · 2014-08-18T21:50:44.000-07:00
Change jqLite's implementation of wrap() to clone the wrapNode before wrapping the target element in it. Match jQuery's wrap() behavior and prevent accidentally attaching target element to the DOM as a side effect. Closes angular#3860 Closes angular#4194
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -842,7 +842,7 @@ forEach({
   },
 
   wrap: function(element, wrapNode) {
-    wrapNode = jqLite(wrapNode)[0];
+    wrapNode = jqLite(wrapNode).eq(0).clone()[0];
     var parent = element.parentNode;
     if (parent) {
       parent.replaceChild(wrapNode, element);
diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js
@@ -1556,6 +1556,14 @@ describe('jqLite', function() {
       text.wrap("<span>");
       expect(text.parent().text()).toEqual('A<a>B</a>C');
     });
+    it('should clone elements to be wrapped around target', function () {
+      var root = jqLite('<div class="sigil"></div>');
+      var span = jqLite('<span>A</span>');
+
+      span.wrap(root);
+      expect(root.children().length).toBe(0);
+      expect(span.parent().hasClass('sigil')).toBeTruthy();
+    });
   });
 
 
