fix(jqLite): addClass should ignore falsy values

IgorMinar · IgorMinar · commit 622c3ec97409 · 2011-09-01T16:37:07.000-07:00
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -162,8 +162,8 @@ function JQLiteRemoveClass(element, selector) {
   );
 }
 
-function JQLiteAddClass(element, selector ) {
-  if (!JQLiteHasClass(element, selector)) {
+function JQLiteAddClass(element, selector) {
+  if (selector && !JQLiteHasClass(element, selector)) {
     element.className = trim(element.className + ' ' + selector);
   }
 }
diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js
@@ -197,6 +197,20 @@ describe('jqLite', function(){
         expect(jqLite(a).hasClass('abc')).toEqual(true);
         expect(jqLite(b).hasClass('abc')).toEqual(true);
       });
+
+      it('should ignore falsy values', function() {
+        var jqA = jqLite(a);
+        expect(jqA[0].className).toBe('');
+
+        jqA.addClass(undefined);
+        expect(jqA[0].className).toBe('');
+
+        jqA.addClass(null);
+        expect(jqA[0].className).toBe('');
+
+        jqA.addClass(false);
+        expect(jqA[0].className).toBe('');
+      });
     });
 
 

Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,8 @@ function JQLiteRemoveClass(element, selector) {`
`162`	`162`	`);`
`163`	`163`	`}`
`164`	`164`
`165`		`-function JQLiteAddClass(element, selector ) {`
`166`		`- if (!JQLiteHasClass(element, selector)) {`
	`165`	`+function JQLiteAddClass(element, selector) {`
	`166`	`+ if (selector && !JQLiteHasClass(element, selector)) {`
`167`	`167`	`element.className = trim(element.className + ' ' + selector);`
`168`	`168`	`}`
`169`	`169`	`}`