chore(IE8): remove more special code for IE8

realityking · Narretz · commit 5d695e556621 · 2016-04-09T22:38:16.000+02:00
Closes angular#9478
diff --git a/src/Angular.js b/src/Angular.js
@@ -240,11 +240,7 @@ function forEach(obj, iterator, context) {
   if (obj) {
     if (isFunction(obj)) {
       for (key in obj) {
-        // Need to check if hasOwnProperty exists,
-        // as on IE8 the result of querySelectorAll is an object without a hasOwnProperty function
-        if (key !== 'prototype' && key !== 'length' && key !== 'name' &&
-          (!obj.hasOwnProperty || obj.hasOwnProperty(key))
-        ) {
+        if (key !== 'prototype' && key !== 'length' && key !== 'name' && obj.hasOwnProperty(key)) {
           iterator.call(context, obj[key], key, obj);
         }
       }
diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -1336,22 +1336,6 @@ describe('angular', function() {
       expect(log).toEqual(['0:a', '1:c']);
     });
 
-    if (document.querySelectorAll) {
-      it('should handle the result of querySelectorAll in IE8 as it has no hasOwnProperty function', function() {
-        document.body.innerHTML = "<p>" +
-          "<a name='x'>a</a>" +
-          "<a name='y'>b</a>" +
-          "<a name='x'>c</a>" +
-          "</p>";
-
-        var htmlCollection = document.querySelectorAll('[name="x"]'),
-          log = [];
-
-        forEach(htmlCollection, function(value, key) { log.push(key + ':' + value.innerHTML); });
-        expect(log).toEqual(['0:a', '1:c']);
-      });
-    }
-
     it('should handle arguments objects like arrays', function() {
       var args,
           log = [];

Original file line number	Diff line number	Diff line change
`@@ -240,11 +240,7 @@ function forEach(obj, iterator, context) {`
`240`	`240`	`if (obj) {`
`241`	`241`	`if (isFunction(obj)) {`
`242`	`242`	`for (key in obj) {`
`243`		`- // Need to check if hasOwnProperty exists,`
`244`		`- // as on IE8 the result of querySelectorAll is an object without a hasOwnProperty function`
`245`		`- if (key !== 'prototype' && key !== 'length' && key !== 'name' &&`
`246`		`- (!obj.hasOwnProperty \|\| obj.hasOwnProperty(key))`
`247`		`- ) {`
	`243`	`+ if (key !== 'prototype' && key !== 'length' && key !== 'name' && obj.hasOwnProperty(key)) {`
`248`	`244`	`iterator.call(context, obj[key], key, obj);`
`249`	`245`	`}`
`250`	`246`	`}`