feat(Angular.js): skip JSON.stringify for undefined

xdissent · pkozlowski-opensource · commit 5a294c864645 · 2013-07-12T20:32:40.000+02:00
Return early in `angular.toJson` if the object to be stringified is `undefined`.
IE8 stringifies `undefined` to `'undefined'` whereas other browsers return
`undefined`. This normalizes behavior and passes currently broken unit tests
in IE8.
diff --git a/src/Angular.js b/src/Angular.js
@@ -775,9 +775,10 @@ function toJsonReplacer(key, value) {
  *
  * @param {Object|Array|Date|string|number} obj Input to be serialized into JSON.
  * @param {boolean=} pretty If set to true, the JSON output will contain newlines and whitespace.
- * @returns {string} Jsonified string representing `obj`.
+ * @returns {string|undefined} Jsonified string representing `obj`.
  */
 function toJson(obj, pretty) {
+  if (typeof obj === 'undefined') return undefined;
   return JSON.stringify(obj, toJsonReplacer, pretty ? '  ' : null);
 }
 
diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -909,6 +909,10 @@ describe('angular', function() {
     it('should not serialize scope instances', inject(function($rootScope) {
       expect(toJson({key: $rootScope})).toEqual('{"key":"$SCOPE"}');
     }));
+
+    it('should serialize undefined as undefined', function() {
+      expect(toJson(undefined)).toEqual(undefined);
+    });
   });
 
 });

Original file line number	Diff line number	Diff line change
`@@ -775,9 +775,10 @@ function toJsonReplacer(key, value) {`
`775`	`775`	`*`
`776`	`776`	`* @param {Object\|Array\|Date\|string\|number} obj Input to be serialized into JSON.`
`777`	`777`	`* @param {boolean=} pretty If set to true, the JSON output will contain newlines and whitespace.`
`778`		- * @returns {string} Jsonified string representing `obj`.
	`778`	+ * @returns {string\|undefined} Jsonified string representing `obj`.
`779`	`779`	`*/`
`780`	`780`	`function toJson(obj, pretty) {`
	`781`	`+ if (typeof obj === 'undefined') return undefined;`
`781`	`782`	`return JSON.stringify(obj, toJsonReplacer, pretty ? ' ' : null);`
`782`	`783`	`}`
`783`	`784`