fix($compile): empty normalized href should pass sanitation check

Anders Hessellund Jensen · petebacondarwin · commit 3b2c6f09cb85 · 2013-07-04T00:13:04.000+01:00
Sometimes IE returns an empty string for its normalized href on a tags. This should pass the sanitation check in $compile. Closes angular#2219, angular#2593
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -293,7 +293,7 @@ function $CompileProvider($provide) {
 
           // href property always returns normalized absolute url, so we can match against that
           normalizedVal = urlSanitizationNode.href;
-          if (!normalizedVal.match(urlSanitizationWhitelist)) {
+          if (normalizedVal !== '' && !normalizedVal.match(urlSanitizationWhitelist)) {
             this[key] = value = 'unsafe:' + normalizedVal;
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ function $CompileProvider($provide) {`
`293`	`293`
`294`	`294`	`// href property always returns normalized absolute url, so we can match against that`
`295`	`295`	`normalizedVal = urlSanitizationNode.href;`
`296`		`- if (!normalizedVal.match(urlSanitizationWhitelist)) {`
	`296`	`+ if (normalizedVal !== '' && !normalizedVal.match(urlSanitizationWhitelist)) {`
`297`	`297`	`this[key] = value = 'unsafe:' + normalizedVal;`
`298`	`298`	`}`
`299`	`299`	`}`