fix($animateCss): do not throw errors when a closing timeout is fired on a removed element

matsko · matsko · commit 2f6b6fb7a1de · 2015-08-27T14:07:59.000-07:00
Closes angular#12650
diff --git a/src/ngAnimate/animateCss.js b/src/ngAnimate/animateCss.js
@@ -894,10 +894,16 @@ var $AnimateCssProvider = ['$animateProvider', function($animateProvider) {
 
         function onAnimationExpired() {
           var animationsData = element.data(ANIMATE_TIMER_KEY);
-          for (var i = 1; i < animationsData.length; i++) {
-            animationsData[i]();
+
+          // this will be false in the event that the element was
+          // removed from the DOM (via a leave animation or something
+          // similar)
+          if (animationsData) {
+            for (var i = 1; i < animationsData.length; i++) {
+              animationsData[i]();
+            }
+            element.removeData(ANIMATE_TIMER_KEY);
           }
-          element.removeData(ANIMATE_TIMER_KEY);
         }
 
         function onAnimationProgress(event) {
diff --git a/test/ngAnimate/animateCssSpec.js b/test/ngAnimate/animateCssSpec.js
@@ -1198,6 +1198,24 @@ describe("ngAnimate $animateCss", function() {
             return animator;
           }
         }));
+
+        it("should not throw an error any pending timeout requests resolve after the element has already been removed",
+          inject(function($animateCss, $$body, $rootElement, $timeout, $animate) {
+
+          var element = jqLite('<div></div>');
+          $rootElement.append(element);
+          $$body.append($rootElement);
+
+          ss.addRule('.red', 'transition:1s linear all;');
+
+          $animateCss(element, { addClass: 'red' }).start();
+          triggerAnimationStartFrame();
+          element.remove();
+
+          expect(function() {
+            $timeout.flush();
+          }).not.toThrow();
+        }));
       });
 
       describe("getComputedStyle", function() {
