chore($q): convert thrown Error to $minErr when calling $q constructor without resolver

jeffbcross · jeffbcross · commit 1b331f372936 · 2014-08-26T12:09:26.000-07:00
diff --git a/docs/content/error/$q/norslvr.ngdoc b/docs/content/error/$q/norslvr.ngdoc
@@ -0,0 +1,17 @@
+@ngdoc error
+@name $q:norslvr
+@fullName No resolver function passed to $Q
+@description
+
+Occurs when calling creating a promise using {@link $q} as a constructor, without providing the
+required `resolver` function.
+
+```
+//bad
+var promise = $q().then(doSomething);
+
+//good
+var promise = $q(function(resolve, reject) {
+  waitForSomethingAsync.then(resolve);
+}).then(doSomething);
+```
diff --git a/src/ng/q.js b/src/ng/q.js
@@ -235,6 +235,7 @@ function $$QProvider() {
  * @returns {object} Promise manager.
  */
 function qFactory(nextTick, exceptionHandler) {
+  var $qMinErr = minErr('$q');
   function callOnce(self, resolveFn, rejectFn) {
     var called = false;
     function wrap(fn) {
@@ -522,8 +523,7 @@ function qFactory(nextTick, exceptionHandler) {
 
   var $Q = function Q(resolver) {
     if (!isFunction(resolver)) {
-      // TODO(@caitp): minErr this
-      throw new TypeError('Expected resolverFn');
+      throw $qMinErr('norslvr', "Expected resolverFn, got '{0}'", resolver);
     }
 
     if (!(this instanceof Q)) {
