fix($animate): make sure the JS animation lookup is an object lookup

matsko · matsko · commit 103a39ca8dad · 2015-04-17T15:41:52.000-07:00
The lookup type was an array before, but it should be an empty object. Closes angular#11619
diff --git a/src/ng/animate.js b/src/ng/animate.js
@@ -163,7 +163,7 @@ var $$CoreAnimateQueueProvider = function() {
 var $AnimateProvider = ['$provide', function($provide) {
   var provider = this;
 
-  this.$$registeredAnimations = [];
+  this.$$registeredAnimations = Object.create(null);
 
    /**
    * @ngdoc method
diff --git a/test/ng/animateSpec.js b/test/ng/animateSpec.js
@@ -115,6 +115,21 @@ describe("$animate", function() {
       inject();
     });
 
+    it("should register the animation and be available for lookup", function() {
+      var provider;
+      module(function($animateProvider) {
+        provider = $animateProvider;
+      });
+      inject(function() {
+        // by using hasOwnProperty we know for sure that the lookup object is an empty object
+        // instead of inhertiting properties from its original prototype.
+        expect(provider.$$registeredAnimations.hasOwnProperty).toBeFalsy();
+
+        provider.register('.filter', noop);
+        expect(provider.$$registeredAnimations['filter']).toBe('.filter-animation');
+      });
+    });
+
     it("should apply and retain inline styles on the element that is animated", inject(function($animate, $rootScope) {
       var element = jqLite('<div></div>');
       var parent = jqLite('<div></div>');
