fix(docs-bootstrap): Removed injector from bootstrapped docs samples

jeffbcross · jeffbcross · commit 0b114fd3e1ce · 2013-08-09T10:19:41.000-07:00
This is necessary to make e2e tests pass for implementing angular#3411. At present, the docs are violating the rule being enforced by double-bootstrap prevention.
diff --git a/docs/components/angular-bootstrap/bootstrap-prettify.js b/docs/components/angular-bootstrap/bootstrap-prettify.js
@@ -241,6 +241,7 @@ directive.ngEmbedApp = ['$templateCache', '$browser', '$rootScope', '$location',
         embedRootScope.$destroy();
       });
 
+      element.data('$injector', null);
       angular.bootstrap(element, modules);
     }
   };
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -330,7 +330,7 @@ function JQLiteInheritedData(element, name, value) {
   }
 
   while (element.length) {
-    if (value = element.data(name)) return value;
+    if ((value = element.data(name)) !== undefined) return value;
     element = element.parent();
   }
 }
diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js
@@ -126,6 +126,20 @@ describe('jqLite', function() {
         dealoc(doc);
       }
     );
+
+    it('should return null values', function () {
+      var ul = jqLite('<ul><li><p><b>deep deep</b><p></li></ul>'),
+          li = ul.find('li'),
+          b = li.find('b');
+
+      ul.data('foo', 'bar');
+      li.data('foo', null);
+      expect(b.inheritedData('foo')).toBe(null);
+      expect(li.inheritedData('foo')).toBe(null);
+      expect(ul.inheritedData('foo')).toBe('bar');
+
+      dealoc(ul);
+    });
   });
 
 
diff --git a/test/testabilityPatch.js b/test/testabilityPatch.js
@@ -56,7 +56,7 @@ afterEach(function() {
   forEachSorted(cache, function(expando, key){
     angular.forEach(expando.data, function(value, key){
       count ++;
-      if (value.$element) {
+      if (value && value.$element) {
         dump('LEAK', key, value.$id, sortedHtml(value.$element));
       } else {
         dump('LEAK', key, angular.toJson(value));

Original file line number	Diff line number	Diff line change
`@@ -241,6 +241,7 @@ directive.ngEmbedApp = ['$templateCache', '$browser', '$rootScope', '$location',`
`241`	`241`	`embedRootScope.$destroy();`
`242`	`242`	`});`
`243`	`243`
	`244`	`+ element.data('$injector', null);`
`244`	`245`	`angular.bootstrap(element, modules);`
`245`	`246`	`}`
`246`	`247`	`};`
Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ function JQLiteInheritedData(element, name, value) {`
`330`	`330`	`}`
`331`	`331`
`332`	`332`	`while (element.length) {`
`333`		`- if (value = element.data(name)) return value;`
	`333`	`+ if ((value = element.data(name)) !== undefined) return value;`
`334`	`334`	`element = element.parent();`
`335`	`335`	`}`
`336`	`336`	`}`