chore: use triple equals comparison with typeof operator.

esarbanis · IgorMinar · commit 02354201963d · 2014-06-27T16:53:13.000-07:00
It is common practice for typeof operator to be used with '==='. Closes angular#8009
diff --git a/src/Angular.js b/src/Angular.js
@@ -1504,7 +1504,7 @@ function assertArgFn(arg, name, acceptArrayAnnotation) {
   }
 
   assertArg(isFunction(arg), name, 'not a function, got ' +
-      (arg && typeof arg == 'object' ? arg.constructor.name || 'Object' : typeof arg));
+      (arg && typeof arg === 'object' ? arg.constructor.name || 'Object' : typeof arg));
   return arg;
 }
 
diff --git a/src/auto/injector.js b/src/auto/injector.js
@@ -84,7 +84,7 @@ function annotate(fn, strictDi, name) {
       argDecl,
       last;
 
-  if (typeof fn == 'function') {
+  if (typeof fn === 'function') {
     if (!($inject = fn.$inject)) {
       $inject = [];
       if (fn.length) {
diff --git a/src/ng/controller.js b/src/ng/controller.js
@@ -74,7 +74,7 @@ function $ControllerProvider() {
       instance = $injector.instantiate(expression, locals, constructor);
 
       if (identifier) {
-        if (!(locals && typeof locals.$scope == 'object')) {
+        if (!(locals && typeof locals.$scope === 'object')) {
           throw minErr('$controller')('noscp',
               "Cannot export controller '{0}' as '{1}'! No $scope object provided via `locals`.",
               constructor || expression.name, identifier);
diff --git a/src/ng/filter/filter.js b/src/ng/filter/filter.js
@@ -195,7 +195,7 @@ function filterFilter() {
         // jshint +W086
         for (var key in expression) {
           (function(path) {
-            if (typeof expression[path] == 'undefined') return;
+            if (typeof expression[path] === 'undefined') return;
             predicates.push(function(value) {
               return search(path == '$' ? value : (value && value[path]), expression[path]);
             });
diff --git a/src/ng/rootScope.js b/src/ng/rootScope.js
@@ -698,7 +698,7 @@ function $RootScopeProvider(){
                     if ((value = watch.get(current)) !== (last = watch.last) &&
                         !(watch.eq
                             ? equals(value, last)
-                            : (typeof value == 'number' && typeof last == 'number'
+                            : (typeof value === 'number' && typeof last === 'number'
                                && isNaN(value) && isNaN(last)))) {
                       dirty = true;
                       lastDirtyWatch = watch;
diff --git a/src/ngScenario/Scenario.js b/src/ngScenario/Scenario.js
@@ -294,7 +294,7 @@ _jQuery.fn.bindings = function(windowJquery, bindExp) {
   function push(value) {
     if (value === undefined) {
       value = '';
-    } else if (typeof value != 'string') {
+    } else if (typeof value !== 'string') {
       value = angular.toJson(value);
     }
     result.push('' + value);

Original file line number	Diff line number	Diff line change
`@@ -1504,7 +1504,7 @@ function assertArgFn(arg, name, acceptArrayAnnotation) {`
`1504`	`1504`	`}`
`1505`	`1505`
`1506`	`1506`	`assertArg(isFunction(arg), name, 'not a function, got ' +`
`1507`		`- (arg && typeof arg == 'object' ? arg.constructor.name \|\| 'Object' : typeof arg));`
	`1507`	`+ (arg && typeof arg === 'object' ? arg.constructor.name \|\| 'Object' : typeof arg));`
`1508`	`1508`	`return arg;`
`1509`	`1509`	`}`
`1510`	`1510`
Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ _jQuery.fn.bindings = function(windowJquery, bindExp) {`
`294`	`294`	`function push(value) {`
`295`	`295`	`if (value === undefined) {`
`296`	`296`	`value = '';`
`297`		`- } else if (typeof value != 'string') {`
	`297`	`+ } else if (typeof value !== 'string') {`
`298`	`298`	`value = angular.toJson(value);`
`299`	`299`	`}`
`300`	`300`	`result.push('' + value);`