Skip to content

Commit f72f137

Browse files
Tim Blasikegluneq
authored andcommitted
ci(dart): Uncomment dart.dev build and make it required
Workaround for dart-lang/dartdoc#1099: remove the `--input=.` parameter to `dartdoc`. Closes angular#6823, angular#6410 Closes angular#6958
1 parent ee3c580 commit f72f137

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

.travis.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ env:
3939
matrix:
4040
# Order: a slower build first, so that we don't occupy an idle travis worker waiting for others to complete.
4141
- MODE=dart DART_CHANNEL=stable DART_VERSION=$DART_STABLE_VERSION
42-
# Disable dart dev build, which is timing out after 2h. #6823
43-
# - MODE=dart DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION
42+
- MODE=dart DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION
4443
- MODE=saucelabs_required DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION
4544
- MODE=browserstack_required DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION
4645
- MODE=saucelabs_optional DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION
@@ -57,8 +56,6 @@ matrix:
5756
allow_failures:
5857
- env: "MODE=saucelabs_optional DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION"
5958
- env: "MODE=browserstack_optional DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION"
60-
# TODO(alxhub): remove when dartdoc #1039 is in dev channel
61-
- env: "MODE=dart DART_CHANNEL=dev DART_VERSION=$DART_DEV_VERSION"
6259
# Tracked in https://github.com/angular/angular/issues/7050
6360
- env: "MODE=typescript_next DART_CHANNEL=stable DART_VERSION=$DART_STABLE_VERSION"
6461

tools/build/dartapidocs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module.exports = function(gulp, plugins, config) {
2121
} else {
2222
console.log('INFO: running dartdoc for ', dir);
2323

24-
var stream = spawn(config.command, ['--input=.', '--output=' + config.output],
24+
var stream = spawn(config.command, ['--output=' + config.output],
2525
{stdio: [process.stdin, process.stdout, process.stderr], cwd: dir});
2626

2727
stream.on('exit', function(code) {

0 commit comments

Comments
 (0)