build(broccoli): make node_trees produce strict-mode scripts

caitp · caitp · commit ed9d9d5096a7 · 2015-06-19T21:19:12.000-04:00
Closes angular#2575 Closes angular#2648
diff --git a/modules/angular2/src/util/decorators.ts b/modules/angular2/src/util/decorators.ts
@@ -127,26 +127,26 @@ export function makeParamDecorator(annotationCls): any {
     if (this instanceof annotationCls) {
       return annotationInstance;
     } else {
-      function ParamDecorator(cls, unusedKey, index) {
-        var parameters: Array<Array<any>> = Reflect.getMetadata('parameters', cls);
-        parameters = parameters || [];
-
-        // there might be gaps if some in between parameters do not have annotations.
-        // we pad with nulls.
-        while (parameters.length <= index) {
-          parameters.push(null);
-        }
+      (<any>ParamDecorator).annotation = annotationInstance;
+      return ParamDecorator;
+    }
 
-        parameters[index] = parameters[index] || [];
-        var annotationsForParam: Array<any> = parameters[index];
-        annotationsForParam.push(annotationInstance);
+    function ParamDecorator(cls, unusedKey, index) {
+      var parameters: Array<Array<any>> = Reflect.getMetadata('parameters', cls);
+      parameters = parameters || [];
 
-        Reflect.defineMetadata('parameters', parameters, cls);
-        return cls;
+      // there might be gaps if some in between parameters do not have annotations.
+      // we pad with nulls.
+      while (parameters.length <= index) {
+        parameters.push(null);
       }
 
-      (<any>ParamDecorator).annotation = annotationInstance;
-      return ParamDecorator;
+      parameters[index] = parameters[index] || [];
+      var annotationsForParam: Array<any> = parameters[index];
+      annotationsForParam.push(annotationInstance);
+
+      Reflect.defineMetadata('parameters', parameters, cls);
+      return cls;
     }
   }
   ParamDecoratorFactory.prototype = Object.create(annotationCls.prototype);
diff --git a/modules/angular2/test/core/compiler/integration_spec.ts b/modules/angular2/test/core/compiler/integration_spec.ts
@@ -1209,22 +1209,21 @@ export function main() {
     // - https://github.com/angular/angular/issues/776
     // - https://github.com/angular/angular/commit/81f3f32
     xdescribe('Missing directive checks', () => {
+      function expectCompileError(tb, inlineTpl, errMessage, done) {
+        tb.overrideView(MyComp, new viewAnn.View({template: inlineTpl}));
+        PromiseWrapper.then(
+            tb.createView(MyComp),
+            (value) => {
+              throw new BaseException(
+                  "Test failure: should not have come here as an exception was expected");
+            },
+            (err) => {
+              expect(err.message).toEqual(errMessage);
+              done();
+            });
+      }
 
       if (assertionsEnabled()) {
-        function expectCompileError(tb, inlineTpl, errMessage, done) {
-          tb.overrideView(MyComp, new viewAnn.View({template: inlineTpl}));
-          PromiseWrapper.then(
-              tb.createView(MyComp),
-              (value) => {
-                throw new BaseException(
-                    "Test failure: should not have come here as an exception was expected");
-              },
-              (err) => {
-                expect(err.message).toEqual(errMessage);
-                done();
-              });
-        }
-
         it('should raise an error if no directive is registered for a template with template bindings',
            inject([TestBed, AsyncTestCompleter], (tb: TestBed, async) => {
              expectCompileError(tb, '<div><div template="if: foo"></div></div>',
diff --git a/tools/broccoli/trees/node_tree.ts b/tools/broccoli/trees/node_tree.ts
@@ -127,5 +127,12 @@ module.exports = function makeNodeTree(destinationPath) {
     ]
   });
 
+  // Prepend 'use strict' directive to all JS files.
+  // See https://github.com/Microsoft/TypeScript/issues/3576
+  nodeTree = replace(nodeTree, {
+    files: ['**/*.js'],
+    patterns: [{match: /^/, replacement: function() { return `'use strict';` }}]
+  });
+
   return destCopy(nodeTree, destinationPath);
 };
