build(dartanalyzer): Ignore TODOs during build

Tim Blasi · kegluneq · commit bd015f14e84c · 2016-01-15T22:53:09.000Z
The newest version of the analyzer emits hints when it encounters TODOs in code, which is breaking the Dart dev version of our build. Ignore TODOs for the purpose of build health. See angular#6410
diff --git a/tools/build/dartanalyzer.js b/tools/build/dartanalyzer.js
@@ -165,16 +165,17 @@ _AnalyzerOutputLine.prototype = {
       lineText =
           '\n' + sourceLine + '\n' + repeat(' ', this.colNum) + repeat('^', this.asciiLineLength);
     }
-    return '[' + this.severity + '] ' + this.errorMsg + ' (' + this.sourcePath + ', line ' +
-           this.lineNum + ', col ' + this.colNum + ')' + lineText;
+    return '[' + this.severity + '] type: ' + this.errorType + ' ' +
+        this.errorMsg + ' (' + this.sourcePath + ', line ' + this.lineNum +
+        ', col ' + this.colNum + ')' + lineText;
   },
 
   shouldIgnore: function() {
     if (this.errorCode.match(/UNUSED_IMPORT/i)) {
       if (this.sourcePath.match(/_analyzer\.dart/)) {
         return true;
       }
-      // TODO remove it once ts2dart propertly generates abstract getters
+      // TODO remove it once ts2dart properly generates abstract getters
       if (this.errorMsg.match(/unimplemented/)) {
         return true;
       }
@@ -189,6 +190,11 @@ _AnalyzerOutputLine.prototype = {
       return true;
     }
 
+    // TODOs shouldn't break our build...
+    if (this.errorCode.match(/TODO/i)) {
+      return true;
+    }
+
     // Don't worry about hints in generated files.
     if (this.isHint && this.sourcePath.match(/generated/i)) {
       return true;
