Skip to content

Commit 63cb12d

Browse files
karakara
committed
dbaa80f fix(forms): number input should report null when blank
1 parent 8c8e5cb commit 63cb12d

758 files changed

Lines changed: 780 additions & 854 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎BUILD_INFO‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Wed Apr 20 20:22:17 UTC 2016
2-
c94442a9f03d4c787758aaced3f9339986e7fdd8
1+
Wed Apr 20 20:30:58 UTC 2016
2+
dbaa80f27de03292927b259b8220b98d325e570c

‎animate.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎animate/testing.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎bundles/angular2-all-testing.umd.dev.js‎

Lines changed: 2 additions & 9 deletions
Large diffs are not rendered by default.

‎bundles/angular2-all.umd.dev.js‎

Lines changed: 2 additions & 9 deletions
Large diffs are not rendered by default.

‎bundles/angular2-all.umd.js‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15469,7 +15469,7 @@ return /******/ (function(modules) { // webpackBootstrap
1546915469
this._renderer.setElementProperty(this._elementRef.nativeElement, 'value', value);
1547015470
};
1547115471
NumberValueAccessor.prototype.registerOnChange = function (fn) {
15472-
this.onChange = function (value) { fn(lang_1.NumberWrapper.parseFloat(value)); };
15472+
this.onChange = function (value) { fn(value == '' ? null : lang_1.NumberWrapper.parseFloat(value)); };
1547315473
};
1547415474
NumberValueAccessor.prototype.registerOnTouched = function (fn) { this.onTouched = fn; };
1547515475
NumberValueAccessor = __decorate([
@@ -16282,7 +16282,6 @@ return /******/ (function(modules) { // webpackBootstrap
1628216282
};
1628316283
var lang_1 = __webpack_require__(5);
1628416284
var collection_1 = __webpack_require__(15);
16285-
var exceptions_1 = __webpack_require__(12);
1628616285
var async_1 = __webpack_require__(40);
1628716286
var core_1 = __webpack_require__(2);
1628816287
var control_container_1 = __webpack_require__(115);
@@ -16372,7 +16371,6 @@ return /******/ (function(modules) { // webpackBootstrap
1637216371
this.ngSubmit = new async_1.EventEmitter();
1637316372
}
1637416373
NgFormModel.prototype.ngOnChanges = function (changes) {
16375-
this._checkFormPresent();
1637616374
if (collection_1.StringMapWrapper.contains(changes, "form")) {
1637716375
var sync = shared_1.composeValidators(this._validators);
1637816376
this.form.validator = validators_1.Validators.compose([this.form.validator, sync]);
@@ -16430,11 +16428,6 @@ return /******/ (function(modules) { // webpackBootstrap
1643016428
dir.valueAccessor.writeValue(ctrl.value);
1643116429
});
1643216430
};
16433-
NgFormModel.prototype._checkFormPresent = function () {
16434-
if (lang_1.isBlank(this.form)) {
16435-
throw new exceptions_1.BaseException("ngFormModel expects a form. Please pass one in. Example: <form [ngFormModel]=\"myCoolForm\">");
16436-
}
16437-
};
1643816431
NgFormModel = __decorate([
1643916432
core_1.Directive({
1644016433
selector: '[ngFormModel]',

‎bundles/angular2-all.umd.min.js‎

Lines changed: 15 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎bundles/angular2.dev.js‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11059,7 +11059,7 @@ System.register("angular2/src/common/forms/directives/number_value_accessor", ["
1105911059
};
1106011060
NumberValueAccessor.prototype.registerOnChange = function(fn) {
1106111061
this.onChange = function(value) {
11062-
fn(lang_1.NumberWrapper.parseFloat(value));
11062+
fn(value == '' ? null : lang_1.NumberWrapper.parseFloat(value));
1106311063
};
1106411064
};
1106511065
NumberValueAccessor.prototype.registerOnTouched = function(fn) {
@@ -11766,7 +11766,7 @@ System.register("angular2/src/common/forms/directives/ng_control_group", ["angul
1176611766
return module.exports;
1176711767
});
1176811768

11769-
System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2/src/facade/lang", "angular2/src/facade/collection", "angular2/src/facade/exceptions", "angular2/src/facade/async", "angular2/core", "angular2/src/common/forms/directives/control_container", "angular2/src/common/forms/directives/shared", "angular2/src/common/forms/validators"], true, function(require, exports, module) {
11769+
System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2/src/facade/lang", "angular2/src/facade/collection", "angular2/src/facade/async", "angular2/core", "angular2/src/common/forms/directives/control_container", "angular2/src/common/forms/directives/shared", "angular2/src/common/forms/validators"], true, function(require, exports, module) {
1177011770
var global = System.global,
1177111771
__define = global.define;
1177211772
global.define = undefined;
@@ -11803,7 +11803,6 @@ System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2
1180311803
};
1180411804
var lang_1 = require("angular2/src/facade/lang");
1180511805
var collection_1 = require("angular2/src/facade/collection");
11806-
var exceptions_1 = require("angular2/src/facade/exceptions");
1180711806
var async_1 = require("angular2/src/facade/async");
1180811807
var core_1 = require("angular2/core");
1180911808
var control_container_1 = require("angular2/src/common/forms/directives/control_container");
@@ -11823,7 +11822,6 @@ System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2
1182311822
this.ngSubmit = new async_1.EventEmitter();
1182411823
}
1182511824
NgFormModel.prototype.ngOnChanges = function(changes) {
11826-
this._checkFormPresent();
1182711825
if (collection_1.StringMapWrapper.contains(changes, "form")) {
1182811826
var sync = shared_1.composeValidators(this._validators);
1182911827
this.form.validator = validators_1.Validators.compose([this.form.validator, sync]);
@@ -11893,11 +11891,6 @@ System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2
1189311891
dir.valueAccessor.writeValue(ctrl.value);
1189411892
});
1189511893
};
11896-
NgFormModel.prototype._checkFormPresent = function() {
11897-
if (lang_1.isBlank(this.form)) {
11898-
throw new exceptions_1.BaseException("ngFormModel expects a form. Please pass one in. Example: <form [ngFormModel]=\"myCoolForm\">");
11899-
}
11900-
};
1190111894
NgFormModel = __decorate([core_1.Directive({
1190211895
selector: '[ngFormModel]',
1190311896
bindings: [formDirectiveProvider],

‎bundles/angular2.js‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11059,7 +11059,7 @@ System.register("angular2/src/common/forms/directives/number_value_accessor", ["
1105911059
};
1106011060
NumberValueAccessor.prototype.registerOnChange = function(fn) {
1106111061
this.onChange = function(value) {
11062-
fn(lang_1.NumberWrapper.parseFloat(value));
11062+
fn(value == '' ? null : lang_1.NumberWrapper.parseFloat(value));
1106311063
};
1106411064
};
1106511065
NumberValueAccessor.prototype.registerOnTouched = function(fn) {
@@ -11766,7 +11766,7 @@ System.register("angular2/src/common/forms/directives/ng_control_group", ["angul
1176611766
return module.exports;
1176711767
});
1176811768

11769-
System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2/src/facade/lang", "angular2/src/facade/collection", "angular2/src/facade/exceptions", "angular2/src/facade/async", "angular2/core", "angular2/src/common/forms/directives/control_container", "angular2/src/common/forms/directives/shared", "angular2/src/common/forms/validators"], true, function(require, exports, module) {
11769+
System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2/src/facade/lang", "angular2/src/facade/collection", "angular2/src/facade/async", "angular2/core", "angular2/src/common/forms/directives/control_container", "angular2/src/common/forms/directives/shared", "angular2/src/common/forms/validators"], true, function(require, exports, module) {
1177011770
var global = System.global,
1177111771
__define = global.define;
1177211772
global.define = undefined;
@@ -11803,7 +11803,6 @@ System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2
1180311803
};
1180411804
var lang_1 = require("angular2/src/facade/lang");
1180511805
var collection_1 = require("angular2/src/facade/collection");
11806-
var exceptions_1 = require("angular2/src/facade/exceptions");
1180711806
var async_1 = require("angular2/src/facade/async");
1180811807
var core_1 = require("angular2/core");
1180911808
var control_container_1 = require("angular2/src/common/forms/directives/control_container");
@@ -11823,7 +11822,6 @@ System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2
1182311822
this.ngSubmit = new async_1.EventEmitter();
1182411823
}
1182511824
NgFormModel.prototype.ngOnChanges = function(changes) {
11826-
this._checkFormPresent();
1182711825
if (collection_1.StringMapWrapper.contains(changes, "form")) {
1182811826
var sync = shared_1.composeValidators(this._validators);
1182911827
this.form.validator = validators_1.Validators.compose([this.form.validator, sync]);
@@ -11893,11 +11891,6 @@ System.register("angular2/src/common/forms/directives/ng_form_model", ["angular2
1189311891
dir.valueAccessor.writeValue(ctrl.value);
1189411892
});
1189511893
};
11896-
NgFormModel.prototype._checkFormPresent = function() {
11897-
if (lang_1.isBlank(this.form)) {
11898-
throw new exceptions_1.BaseException("ngFormModel expects a form. Please pass one in. Example: <form [ngFormModel]=\"myCoolForm\">");
11899-
}
11900-
};
1190111894
NgFormModel = __decorate([core_1.Directive({
1190211895
selector: '[ngFormModel]',
1190311896
bindings: [formDirectiveProvider],

‎bundles/angular2.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)