fix: allow creation of var with camelCased names

pkozlowski-opensource · mhevery · commit 59a1f836a25c · 2015-03-17T21:39:26.000-07:00
Closes angular#957
diff --git a/modules/angular2/src/core/compiler/pipeline/compile_element.js b/modules/angular2/src/core/compiler/pipeline/compile_element.js
@@ -134,7 +134,7 @@ export class CompileElement {
     // by the "value", or exported identifier. For example, ng-repeat sets a view local of "index".
     // When this occurs, a lookup keyed by "index" must occur to find if there is a var referencing
     // it.
-    MapWrapper.set(this.variableBindings, variableValue, variableName);
+    MapWrapper.set(this.variableBindings, variableValue, dashCaseToCamelCase(variableName));
   }
 
   addEventBinding(eventName:string, expression:AST) {
diff --git a/modules/angular2/test/core/compiler/integration_spec.js b/modules/angular2/test/core/compiler/integration_spec.js
@@ -419,6 +419,23 @@ export function main() {
         })
       }));
 
+
+      it('should assign the element instance to a user-defined variable with camelCase using dash-case', inject([AsyncTestCompleter], (async) => {
+        tplResolver.setTemplate(MyComp,
+          new Template({inline: '<p><div var-super-alice><i>Hello</i></div></p>'}));
+
+        compiler.compile(MyComp).then((pv) => {
+          createView(pv);
+          expect(view.locals).not.toBe(null);
+
+          var value = view.locals.get('superAlice');
+          expect(value).not.toBe(null);
+          expect(value.tagName.toLowerCase()).toEqual('div');
+
+          async.done();
+        })
+      }));
+
       it('should provide binding configuration config to the component', inject([AsyncTestCompleter], (async) => {
         tplResolver.setTemplate(MyComp, new Template({
           inline: '<push-cmp #cmp></push-cmp>',

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ export class CompileElement {`
`134`	`134`	`// by the "value", or exported identifier. For example, ng-repeat sets a view local of "index".`
`135`	`135`	`// When this occurs, a lookup keyed by "index" must occur to find if there is a var referencing`
`136`	`136`	`// it.`
`137`		`- MapWrapper.set(this.variableBindings, variableValue, variableName);`
	`137`	`+ MapWrapper.set(this.variableBindings, variableValue, dashCaseToCamelCase(variableName));`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`addEventBinding(eventName:string, expression:AST) {`