Skip to content

Commit 529988b

Browse files
committed
Fix DDC errors
1 parent c17dc1c commit 529988b

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

modules/angular2/src/core/application_ref.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ export class PlatformRef_ extends PlatformRef {
250250
provide(ApplicationRef, {useFactory: (): ApplicationRef => app, deps: []})
251251
]);
252252

253-
var exceptionHandler: Function;
253+
var exceptionHandler: ExceptionHandler;
254254
try {
255255
injector = this.injector.resolveAndCreateChild(providers);
256256
exceptionHandler = injector.get(ExceptionHandler);

modules/angular2/src/core/reflection/reflection_capabilities.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,8 @@ class ReflectionCapabilities implements PlatformReflectionCapabilities {
246246
List _convertParameter(ParameterMirror p) {
247247
var t = p.type;
248248
var res = (!t.hasReflectedType || t.reflectedType == dynamic)
249-
? []
250-
: [t.reflectedType];
249+
? <Object>[]
250+
: <Object>[t.reflectedType];
251251
res.addAll(p.metadata.map((m) => m.reflectee));
252252
return res;
253253
}

modules/angular2/src/router/router.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,9 @@ export class Router {
338338
return false;
339339
}
340340
if (isPresent(this._childRouter)) {
341-
return this._childRouter._routerCanDeactivate(childInstruction);
341+
// TODO: ideally, this closure would map to async-await in Dart.
342+
// For now, casting to any to suppress an error.
343+
return <any>this._childRouter._routerCanDeactivate(childInstruction);
342344
}
343345
return true;
344346
});

scripts/ci/build_dart_ddc.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ cd $REPO_ROOT_DIR
1515
DDC_TOTAL_WARNING_CAP="210"
1616
DDC_TOTAL_ERROR_CAP="0"
1717
DDC_DIR=`pwd`/tmp/dev_compiler
18-
DDC_VERSION="0.1.20"
18+
DDC_VERSION="0.1.23"
1919

2020
# Get DDC
2121
mkdir -p tmp

0 commit comments

Comments
 (0)