fix(http): throw if url is not string or Request

Brian Yarger · Brian Yarger · commit 3525d8a3947b · 2015-09-18T23:33:17.000Z
Closes angular#4245 Closes angular#4257
diff --git a/modules/angular2/src/http/http.ts b/modules/angular2/src/http/http.ts
@@ -120,6 +120,8 @@ export class Http {
           new Request(mergeOptions(this._defaultOptions, options, RequestMethods.Get, url)));
     } else if (url instanceof Request) {
       responseObservable = httpRequest(this._backend, url);
+    } else {
+      throw makeTypeError('First argument must be a url string or Request instance.');
     }
     return responseObservable;
   }
@@ -201,6 +203,8 @@ export class Jsonp extends Http {
         makeTypeError('JSONP requests must use GET request method.');
       }
       responseObservable = httpRequest(this._backend, url);
+    } else {
+      throw makeTypeError('First argument must be a url string or Request instance.');
     }
     return responseObservable;
   }
diff --git a/modules/angular2/test/http/http_spec.ts b/modules/angular2/test/http/http_spec.ts
@@ -103,6 +103,7 @@ export function main() {
     var injector: Injector;
     var backend: MockBackend;
     var baseResponse;
+    var jsonp: Jsonp;
     beforeEach(() => {
       injector = Injector.resolveAndCreate([
         BaseRequestOptions,
@@ -111,9 +112,15 @@ export function main() {
             function(backend: ConnectionBackend, defaultOptions: BaseRequestOptions) {
               return new Http(backend, defaultOptions);
             },
+            [MockBackend, BaseRequestOptions]),
+        bind(Jsonp).toFactory(
+            function(backend: ConnectionBackend, defaultOptions: BaseRequestOptions) {
+              return new Jsonp(backend, defaultOptions);
+            },
             [MockBackend, BaseRequestOptions])
       ]);
       http = injector.get(Http);
+      jsonp = injector.get(Jsonp);
       backend = injector.get(MockBackend);
       baseResponse = new Response(new ResponseOptions({body: 'base response'}));
     });
@@ -160,6 +167,13 @@ export function main() {
         //         async.done();
         //       });
         //     }));
+
+
+        it('should throw if url is not a string or Request', () => {
+          var req = <Request>{};
+          expect(() => http.request(req))
+              .toThrowError('First argument must be a url string or Request instance.');
+        });
       });
 
 
@@ -306,5 +320,15 @@ export function main() {
            }));
       });
     });
+
+    describe('Jsonp', () => {
+      describe('.request()', () => {
+        it('should throw if url is not a string or Request', () => {
+          var req = <Request>{};
+          expect(() => jsonp.request(req))
+              .toThrowError('First argument must be a url string or Request instance.');
+        });
+      });
+    });
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,8 @@ export class Http {`
`120`	`120`	`new Request(mergeOptions(this._defaultOptions, options, RequestMethods.Get, url)));`
`121`	`121`	`} else if (url instanceof Request) {`
`122`	`122`	`responseObservable = httpRequest(this._backend, url);`
	`123`	`+ } else {`
	`124`	`+ throw makeTypeError('First argument must be a url string or Request instance.');`
`123`	`125`	`}`
`124`	`126`	`return responseObservable;`
`125`	`127`	`}`
`@@ -201,6 +203,8 @@ export class Jsonp extends Http {`
`201`	`203`	`makeTypeError('JSONP requests must use GET request method.');`
`202`	`204`	`}`
`203`	`205`	`responseObservable = httpRequest(this._backend, url);`
	`206`	`+ } else {`
	`207`	`+ throw makeTypeError('First argument must be a url string or Request instance.');`
`204`	`208`	`}`
`205`	`209`	`return responseObservable;`
`206`	`210`	`}`