fix(core): return the ChangeDetectorRef of the component also for embedded views.

tbosch · tbosch · commit 351f24e8ebb4 · 2016-04-29T18:30:30.000-07:00
diff --git a/modules/angular2/src/compiler/view_compiler/compile_element.ts b/modules/angular2/src/compiler/view_compiler/compile_element.ts
@@ -306,7 +306,7 @@ export class CompileElement extends CompileNode {
           if (requestingProviderType === ProviderAstType.Component) {
             return this._compViewExpr.prop('ref');
           } else {
-            return o.THIS_EXPR.prop('ref');
+            return getPropertyInView(o.THIS_EXPR.prop('ref'), this.view, this.view.componentView);
           }
         }
       }
diff --git a/modules/angular2/src/compiler/view_compiler/compile_pipe.ts b/modules/angular2/src/compiler/view_compiler/compile_pipe.ts
@@ -25,7 +25,7 @@ export class CompilePipe {
   create(): void {
     var deps = this.meta.type.diDeps.map((diDep) => {
       if (diDep.token.equalsTo(identifierToken(Identifiers.ChangeDetectorRef))) {
-        return o.THIS_EXPR.prop('ref');
+        return getPropertyInView(o.THIS_EXPR.prop('ref'), this.view, this.view.componentView);
       }
       return injectFromViewParentInjector(diDep.token, false);
     });
diff --git a/modules/angular2/test/core/linker/view_injector_integration_spec.ts b/modules/angular2/test/core/linker/view_injector_integration_spec.ts
@@ -591,17 +591,21 @@ export function main() {
          fakeAsync(() => {
            var cf = createCompFixture(
                '<div componentNeedsChangeDetectorRef></div>',
-               tcb.overrideTemplate(PushComponentNeedsChangeDetectorRef,
-                                    '{{counter}}<div directiveNeedsChangeDetectorRef></div>'));
+               tcb.overrideTemplate(
+                   PushComponentNeedsChangeDetectorRef,
+                   '{{counter}}<div directiveNeedsChangeDetectorRef></div><div *ngIf="true" directiveNeedsChangeDetectorRef></div>'));
            cf.detectChanges();
            var compEl = cf.debugElement.children[0];
-           var comp = compEl.inject(PushComponentNeedsChangeDetectorRef);
+           var comp: PushComponentNeedsChangeDetectorRef =
+               compEl.inject(PushComponentNeedsChangeDetectorRef);
            comp.counter = 1;
            cf.detectChanges();
            expect(compEl.nativeElement).toHaveText('0');
-           compEl.children[0]
-               .inject(DirectiveNeedsChangeDetectorRef)
-               .changeDetectorRef.markForCheck();
+           expect(compEl.children[0].inject(DirectiveNeedsChangeDetectorRef).changeDetectorRef)
+               .toBe(comp.changeDetectorRef);
+           expect(compEl.children[1].inject(DirectiveNeedsChangeDetectorRef).changeDetectorRef)
+               .toBe(comp.changeDetectorRef);
+           comp.changeDetectorRef.markForCheck();
            cf.detectChanges();
            expect(compEl.nativeElement).toHaveText('1');
          }));

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ export class CompileElement extends CompileNode {`
`306`	`306`	`if (requestingProviderType === ProviderAstType.Component) {`
`307`	`307`	`return this._compViewExpr.prop('ref');`
`308`	`308`	`} else {`
`309`		`- return o.THIS_EXPR.prop('ref');`
	`309`	`+ return getPropertyInView(o.THIS_EXPR.prop('ref'), this.view, this.view.componentView);`
`310`	`310`	`}`
`311`	`311`	`}`
`312`	`312`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class CompilePipe {`
`25`	`25`	`create(): void {`
`26`	`26`	`var deps = this.meta.type.diDeps.map((diDep) => {`
`27`	`27`	`if (diDep.token.equalsTo(identifierToken(Identifiers.ChangeDetectorRef))) {`
`28`		`- return o.THIS_EXPR.prop('ref');`
	`28`	`+ return getPropertyInView(o.THIS_EXPR.prop('ref'), this.view, this.view.componentView);`
`29`	`29`	`}`
`30`	`30`	`return injectFromViewParentInjector(diDep.token, false);`
`31`	`31`	`});`