style(lang): add missing type annotation js/dart

PatrickJS · rkirov · commit 1d0de3ea5420 · 2015-01-20T14:12:09.000-08:00
diff --git a/modules/facade/src/lang.dart b/modules/facade/src/lang.dart
@@ -53,7 +53,7 @@ class StringWrapper {
     return parts;
   }
 
-  static equals(String s, String s2) {
+  static bool equals(String s, String s2) {
     return s == s2;
   }
 
@@ -150,7 +150,7 @@ bool isJsObject(o) {
 }
 
 
-assertionsEnabled() {
+bool assertionsEnabled() {
   try {
     assert(false);
     return false;
diff --git a/modules/facade/src/lang.es6 b/modules/facade/src/lang.es6
@@ -44,7 +44,7 @@ export function stringify(token):string {
 }
 
 export class StringWrapper {
-  static fromCharCode(code:int) {
+  static fromCharCode(code:int):string {
     return String.fromCharCode(code);
   }
 
@@ -56,11 +56,11 @@ export class StringWrapper {
     return s.split(regExp.multiple);
   }
 
-  static equals(s:string, s2:string) {
+  static equals(s:string, s2:string):boolean {
     return s === s2;
   }
 
-  static replaceAll(s:string, from:RegExp, replace:string) {
+  static replaceAll(s:string, from:RegExp, replace:string):string {
     return s.replace(from.multiple, replace);
   }
 }
@@ -122,14 +122,14 @@ export class NumberWrapper {
     return parseFloat(text);
   }
 
-  static isNaN(value) {
-    return isNaN(value);
-  }
-
   static get NaN():number {
     return NaN;
   }
 
+  static isNaN(value):boolean {
+    return isNaN(value);
+  }
+
   static isInteger(value):boolean {
     return Number.isInteger(value);
   }
@@ -200,7 +200,7 @@ export function isJsObject(o):boolean {
   return o !== null && (typeof o === "function" || typeof o === "object");
 }
 
-export function assertionsEnabled() {
+export function assertionsEnabled():boolean {
   try {
     var x:int = "string";
     return false;

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ class StringWrapper {`
`53`	`53`	`return parts;`
`54`	`54`	`}`
`55`	`55`
`56`		`- static equals(String s, String s2) {`
	`56`	`+ static bool equals(String s, String s2) {`
`57`	`57`	`return s == s2;`
`58`	`58`	`}`
`59`	`59`
`@@ -150,7 +150,7 @@ bool isJsObject(o) {`
`150`	`150`	`}`
`151`	`151`
`152`	`152`
`153`		`-assertionsEnabled() {`
	`153`	`+bool assertionsEnabled() {`
`154`	`154`	`try {`
`155`	`155`	`assert(false);`
`156`	`156`	`return false;`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export function stringify(token):string {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`export class StringWrapper {`
`47`		`- static fromCharCode(code:int) {`
	`47`	`+ static fromCharCode(code:int):string {`
`48`	`48`	`return String.fromCharCode(code);`
`49`	`49`	`}`
`50`	`50`
`@@ -56,11 +56,11 @@ export class StringWrapper {`
`56`	`56`	`return s.split(regExp.multiple);`
`57`	`57`	`}`
`58`	`58`
`59`		`- static equals(s:string, s2:string) {`
	`59`	`+ static equals(s:string, s2:string):boolean {`
`60`	`60`	`return s === s2;`
`61`	`61`	`}`
`62`	`62`
`63`		`- static replaceAll(s:string, from:RegExp, replace:string) {`
	`63`	`+ static replaceAll(s:string, from:RegExp, replace:string):string {`
`64`	`64`	`return s.replace(from.multiple, replace);`
`65`	`65`	`}`
`66`	`66`	`}`
`@@ -122,14 +122,14 @@ export class NumberWrapper {`
`122`	`122`	`return parseFloat(text);`
`123`	`123`	`}`
`124`	`124`
`125`		`- static isNaN(value) {`
`126`		`- return isNaN(value);`
`127`		`- }`
`128`		`-`
`129`	`125`	`static get NaN():number {`
`130`	`126`	`return NaN;`
`131`	`127`	`}`
`132`	`128`
	`129`	`+ static isNaN(value):boolean {`
	`130`	`+ return isNaN(value);`
	`131`	`+ }`
	`132`	`+`
`133`	`133`	`static isInteger(value):boolean {`
`134`	`134`	`return Number.isInteger(value);`
`135`	`135`	`}`
`@@ -200,7 +200,7 @@ export function isJsObject(o):boolean {`
`200`	`200`	`return o !== null && (typeof o === "function" \|\| typeof o === "object");`
`201`	`201`	`}`
`202`	`202`
`203`		`-export function assertionsEnabled() {`
	`203`	`+export function assertionsEnabled():boolean {`
`204`	`204`	`try {`
`205`	`205`	`var x:int = "string";`
`206`	`206`	`return false;`