Skip to content

Commit 73945bf

Browse files
binarywangbinarywang
committed
规范化代码
1 parent 856b021 commit 73945bf

3 files changed

Lines changed: 31 additions & 30 deletions

File tree

‎weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/WxMpUserService.java‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,22 @@
11
package me.chanjar.weixin.mp.api;
22

3+
import java.util.List;
4+
35
import me.chanjar.weixin.common.error.WxErrorException;
46
import me.chanjar.weixin.mp.bean.WxMpUserQuery;
57
import me.chanjar.weixin.mp.bean.result.WxMpUser;
68
import me.chanjar.weixin.mp.bean.result.WxMpUserList;
79

8-
import java.util.List;
9-
1010
/**
11-
* 用户管理相关操作接口
11+
* 用户管理相关操作接口.
1212
*
1313
* @author Binary Wang
1414
*/
1515
public interface WxMpUserService {
16+
String USER_INFO_BATCH_GET_URL = "https://api.weixin.qq.com/cgi-bin/user/info/batchget";
17+
String USER_GET_URL = "https://api.weixin.qq.com/cgi-bin/user/get";
18+
String USER_INFO_URL = "https://api.weixin.qq.com/cgi-bin/user/info";
19+
String USER_INFO_UPDATE_REMARK_URL = "https://api.weixin.qq.com/cgi-bin/user/info/updateremark";
1620

1721
/**
1822
* <pre>
@@ -61,9 +65,9 @@ public interface WxMpUserService {
6165
* 接口地址：https://api.weixin.qq.com/cgi-bin/user/info/batchget?access_token=ACCESS_TOKEN
6266
* </pre>
6367
*
64-
* @param openids 用户openid列表
68+
* @param openidList 用户openid列表
6569
*/
66-
List<WxMpUser> userInfoList(List<String> openids) throws WxErrorException;
70+
List<WxMpUser> userInfoList(List<String> openidList) throws WxErrorException;
6771

6872
/**
6973
* <pre>

‎weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpUserServiceImpl.java‎

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package me.chanjar.weixin.mp.api.impl;
22

3+
import java.util.List;
4+
35
import com.google.gson.JsonObject;
46
import me.chanjar.weixin.common.error.WxErrorException;
57
import me.chanjar.weixin.mp.api.WxMpService;
@@ -8,13 +10,12 @@
810
import me.chanjar.weixin.mp.bean.result.WxMpUser;
911
import me.chanjar.weixin.mp.bean.result.WxMpUserList;
1012

11-
import java.util.List;
12-
1313
/**
1414
* Created by Binary Wang on 2016/7/21.
15+
*
16+
* @author BinaryWang
1517
*/
1618
public class WxMpUserServiceImpl implements WxMpUserService {
17-
private static final String API_URL_PREFIX = "https://api.weixin.qq.com/cgi-bin/user";
1819
private WxMpService wxMpService;
1920

2021
public WxMpUserServiceImpl(WxMpService wxMpService) {
@@ -23,11 +24,10 @@ public WxMpUserServiceImpl(WxMpService wxMpService) {
2324

2425
@Override
2526
public void userUpdateRemark(String openid, String remark) throws WxErrorException {
26-
String url = API_URL_PREFIX + "/info/updateremark";
2727
JsonObject json = new JsonObject();
2828
json.addProperty("openid", openid);
2929
json.addProperty("remark", remark);
30-
this.wxMpService.post(url, json.toString());
30+
this.wxMpService.post(USER_INFO_UPDATE_REMARK_URL, json.toString());
3131
}
3232

3333
@Override
@@ -37,32 +37,28 @@ public WxMpUser userInfo(String openid) throws WxErrorException {
3737

3838
@Override
3939
public WxMpUser userInfo(String openid, String lang) throws WxErrorException {
40-
String url = API_URL_PREFIX + "/info";
4140
lang = lang == null ? "zh_CN" : lang;
42-
String responseContent = this.wxMpService.get(url,
41+
String responseContent = this.wxMpService.get(USER_INFO_URL,
4342
"openid=" + openid + "&lang=" + lang);
4443
return WxMpUser.fromJson(responseContent);
4544
}
4645

4746
@Override
48-
public WxMpUserList userList(String next_openid) throws WxErrorException {
49-
String url = API_URL_PREFIX + "/get";
50-
String responseContent = this.wxMpService.get(url,
51-
next_openid == null ? null : "next_openid=" + next_openid);
47+
public WxMpUserList userList(String nextOpenid) throws WxErrorException {
48+
String responseContent = this.wxMpService.get(USER_GET_URL,
49+
nextOpenid == null ? null : "next_openid=" + nextOpenid);
5250
return WxMpUserList.fromJson(responseContent);
5351
}
5452

5553
@Override
56-
public List<WxMpUser> userInfoList(List<String> openids)
54+
public List<WxMpUser> userInfoList(List<String> openidList)
5755
throws WxErrorException {
58-
return this.userInfoList(new WxMpUserQuery(openids));
56+
return this.userInfoList(new WxMpUserQuery(openidList));
5957
}
6058

6159
@Override
6260
public List<WxMpUser> userInfoList(WxMpUserQuery userQuery) throws WxErrorException {
63-
String url = API_URL_PREFIX + "/info/batchget";
64-
String responseContent = this.wxMpService.post(url,
65-
userQuery.toJsonString());
61+
String responseContent = this.wxMpService.post(USER_INFO_BATCH_GET_URL, userQuery.toJsonString());
6662
return WxMpUser.fromJsonList(responseContent);
6763
}
6864

‎weixin-java-mp/src/test/java/me/chanjar/weixin/mp/api/impl/WxMpUserServiceImplTest.java‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
package me.chanjar.weixin.mp.api.impl;
22

3+
import java.util.ArrayList;
4+
import java.util.List;
5+
6+
import org.testng.*;
7+
import org.testng.annotations.*;
8+
39
import com.google.inject.Inject;
410
import me.chanjar.weixin.common.error.WxErrorException;
511
import me.chanjar.weixin.mp.api.WxMpService;
@@ -8,19 +14,14 @@
814
import me.chanjar.weixin.mp.bean.WxMpUserQuery;
915
import me.chanjar.weixin.mp.bean.result.WxMpUser;
1016
import me.chanjar.weixin.mp.bean.result.WxMpUserList;
11-
import org.testng.*;
12-
import org.testng.annotations.*;
13-
14-
import java.util.ArrayList;
15-
import java.util.List;
1617

1718
/**
1819
* 测试用户相关的接口
1920
*
2021
* @author chanjarster
2122
* @author Binary Wang
2223
*/
23-
@Test(groups = "userAPI")
24+
@Test
2425
@Guice(modules = ApiTestModule.class)
2526
public class WxMpUserServiceImplTest {
2627

@@ -68,9 +69,9 @@ public void testUserInfoListByWxMpUserQuery() throws WxErrorException {
6869
public void testUserList() throws WxErrorException {
6970
WxMpUserList wxMpUserList = this.wxService.getUserService().userList(null);
7071
Assert.assertNotNull(wxMpUserList);
71-
Assert.assertFalse(wxMpUserList.getCount() == -1);
72-
Assert.assertFalse(wxMpUserList.getTotal() == -1);
73-
Assert.assertFalse(wxMpUserList.getOpenids().size() == -1);
72+
Assert.assertNotEquals(-1, wxMpUserList.getCount());
73+
Assert.assertNotEquals(-1, wxMpUserList.getTotal());
74+
Assert.assertNotEquals(-1, wxMpUserList.getOpenids().size());
7475
System.out.println(wxMpUserList);
7576
}
7677

0 commit comments

Comments
 (0)