Handle missing values.

tomkraljevic · tomkraljevic · commit 06feaccb154e · 2015-09-17T08:03:08.000-07:00
diff --git a/tutorials/pojo_webapp/src/main/java/org/gradle/PredictServlet.java b/tutorials/pojo_webapp/src/main/java/org/gradle/PredictServlet.java
@@ -11,7 +11,7 @@
 
 public class PredictServlet extends HttpServlet {
   private BinomialModelPrediction predict (RowData row) throws Exception {
-    // Improve performance by not instantiating the model every call.
+    // Potential improvement for performance by not instantiating a new model every time.
     MyModel rawModel = new MyModel();
     EasyPredictModelWrapper model = new EasyPredictModelWrapper(rawModel);
 
@@ -31,7 +31,9 @@ public void doGet (HttpServletRequest request, HttpServletResponse response) thr
       String[] values = entry.getValue();
       for (String value : values) {
         System.out.println("Key: " + key + " Value: " + value);
-        row.put(key, value);
+        if (value.length() > 0) {
+          row.put(key, value);
+        }
       }
     }
 
@@ -69,6 +71,7 @@ else if (Double.isInfinite(d)) {
     }
     catch (Exception e) {
       // Prediction failed.
+      System.out.println(e.getMessage());
       response.sendError(HttpServletResponse.SC_NOT_ACCEPTABLE, e.getMessage());
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`public class PredictServlet extends HttpServlet {`
`13`	`13`	`private BinomialModelPrediction predict (RowData row) throws Exception {`
`14`		`- // Improve performance by not instantiating the model every call.`
	`14`	`+ // Potential improvement for performance by not instantiating a new model every time.`
`15`	`15`	`MyModel rawModel = new MyModel();`
`16`	`16`	`EasyPredictModelWrapper model = new EasyPredictModelWrapper(rawModel);`
`17`	`17`
`@@ -31,7 +31,9 @@ public void doGet (HttpServletRequest request, HttpServletResponse response) thr`
`31`	`31`	`String[] values = entry.getValue();`
`32`	`32`	`for (String value : values) {`
`33`	`33`	`System.out.println("Key: " + key + " Value: " + value);`
`34`		`- row.put(key, value);`
	`34`	`+ if (value.length() > 0) {`
	`35`	`+ row.put(key, value);`
	`36`	`+ }`
`35`	`37`	`}`
`36`	`38`	`}`
`37`	`39`
`@@ -69,6 +71,7 @@ else if (Double.isInfinite(d)) {`
`69`	`71`	`}`
`70`	`72`	`catch (Exception e) {`
`71`	`73`	`// Prediction failed.`
	`74`	`+ System.out.println(e.getMessage());`
`72`	`75`	`response.sendError(HttpServletResponse.SC_NOT_ACCEPTABLE, e.getMessage());`
`73`	`76`	`}`
`74`	`77`	`}`