Checkstyle: class design.

KostyaSha · KostyaSha · commit e835537d195c · 2016-02-03T03:44:17.000+03:00
Utility classes should not have a public or default constructor.
diff --git a/src/main/java/com/github/dockerjava/core/GoLangFileMatch.java b/src/main/java/com/github/dockerjava/core/GoLangFileMatch.java
@@ -44,6 +44,8 @@
  *
  */
 public class GoLangFileMatch {
+    private GoLangFileMatch() {
+    }
 
     public static final boolean IS_WINDOWS = File.separatorChar == '\\';
 
diff --git a/src/main/java/com/github/dockerjava/core/NameParser.java b/src/main/java/com/github/dockerjava/core/NameParser.java
@@ -14,6 +14,9 @@
 
 @SuppressWarnings(value = "checkstyle:equalshashcode")
 public class NameParser {
+    private NameParser() {
+    }
+
     //CHECKSTYLE:OFF
     private static final int RepositoryNameTotalLengthMax = 255;
 
diff --git a/src/main/java/com/github/dockerjava/core/util/FiltersEncoder.java b/src/main/java/com/github/dockerjava/core/util/FiltersEncoder.java
@@ -16,6 +16,8 @@
  *
  */
 public class FiltersEncoder {
+    private FiltersEncoder() {
+    }
 
     private static final ObjectMapper OBJECT_MAPPER = new JacksonJaxbJsonProvider().locateMapper(Map.class,
             MediaType.APPLICATION_JSON_TYPE);
diff --git a/src/test/resources/checkstyle/checkstyle-config.xml b/src/test/resources/checkstyle/checkstyle-config.xml
@@ -148,6 +148,13 @@
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>
 
+        <!-- Checks for class design                         -->
+        <!-- See http://checkstyle.sf.net/config_design.html -->
+        <module name="HideUtilityClassConstructor"/>
+        <module name="InterfaceIsType"/>
+        <!-- FIXME check with @marcuslinke -->
+        <!--<module name="VisibilityModifier"/>-->
+
     </module>
 
 </module>

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,8 @@`
`44`	`44`	`*`
`45`	`45`	`*/`
`46`	`46`	`public class GoLangFileMatch {`
	`47`	`+ private GoLangFileMatch() {`
	`48`	`+ }`
`47`	`49`
`48`	`50`	`public static final boolean IS_WINDOWS = File.separatorChar == '\\';`
`49`	`51`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@`
`16`	`16`	`*`
`17`	`17`	`*/`
`18`	`18`	`public class FiltersEncoder {`
	`19`	`+ private FiltersEncoder() {`
	`20`	`+ }`
`19`	`21`
`20`	`22`	`private static final ObjectMapper OBJECT_MAPPER = new JacksonJaxbJsonProvider().locateMapper(Map.class,`
`21`	`23`	`MediaType.APPLICATION_JSON_TYPE);`