Switch DownloadChemCompProvider to use NIO for moving

sbliven · sbliven · commit e0c1ede64979 · 2016-04-06T12:42:43.000+02:00
Files.move seems to be more robust than File.renameTo. This fixed a bug on my system.
diff --git a/biojava-structure/src/main/java/org/biojava/nbio/structure/io/mmcif/DownloadChemCompProvider.java b/biojava-structure/src/main/java/org/biojava/nbio/structure/io/mmcif/DownloadChemCompProvider.java
@@ -31,6 +31,9 @@
 import java.io.StringWriter;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -376,16 +379,11 @@ private static boolean downloadChemCompRecord(String recordName) {
 				}
 
 				pw.flush();
-				// Now we move this across to where it actually wants to be
-				boolean couldRename = newFile.renameTo(new File(localName));
-
-				if (!couldRename) {
-
-					throw new IOException("Could not rename temp file "+newFile.toString()+" to file " + localName);
-				}
-
-				return true;
 			}
+			// Now we move this across to where it actually wants to be
+			Files.move(newFile.toPath(), Paths.get(localName), StandardCopyOption.REPLACE_EXISTING);
+
+			return true;
 		}  catch (IOException e){
 			logger.error("Could not download "+url.toString()+" OR store locally to "+localName+" Error ="+e.getMessage());
 			newFile.delete();
