Skip to content

Commit 2798876

Browse files
committed
distance have to be looked up by element name, not atom name
1 parent f8ac919 commit 2798876

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

biojava-modfinder/src/main/java/org/biojava/nbio/protmod/structure/StructureUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ public static Atom[] findLinkage(final Group group1, final Group group2,
250250

251251
if ( a1.getElement().isMetal() || a2.getElement().isMetal()){
252252

253-
MetalBondDistance defined = getMetalDistanceCutoff(a1.getName(),a2.getName());
253+
MetalBondDistance defined = getMetalDistanceCutoff(a1.getElement().name(),a2.getElement().name());
254254

255255
if ( defined != null) {
256256

biojava-modfinder/src/test/java/org/biojava/nbio/protmod/structure/ProteinModificationParserTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,23 @@ public static String[][] setUpShortTest() {
8888
{"3H8L", "AA0513"}, // CYS-S3H-CYS
8989
{"1CAD", null}, // FE and 4 Cys, cross-link4
9090

91-
// Terbium
91+
// Terbium cases
9292
{"1NCZ", null},
9393
{"3LTQ",null}, // has metalc,
94-
9594
{"4ESQ",null},
9695
{"1TJB",null},
9796
{"2V15",null},
9897
{"2K61",null},
9998

99+
// iron bond to CYS
100+
//{"1G20","AA0300"},
101+
102+
{"3CM6",null},
103+
{"1W6Z",null},
104+
//{"1Z2M",null}, distances are too big for the new cutoffs
105+
{"2O6N",null},
106+
{"1GA7",null},
107+
100108
};
101109
return strucs;
102110
}

0 commit comments

Comments
 (0)