Apply suggestions from code review

havanagrawal · nbdgit · web-flow · commit 230f04f61415 · 2019-05-03T00:31:43.000+05:30
Co-Authored-By: nbdgit &lt;48550673+nbdgit@users.noreply.github.com&gt;
diff --git a/src/main/java/com/conversions/BinaryToGray.java b/src/main/java/com/conversions/BinaryToGray.java
@@ -3,28 +3,26 @@
 public class BinaryToGray
 {
 	/*	This method convert the binary number into gray code
-		@param binaryno need to convert binary number into gray code
+		@param binarycode need to convert binary number into gray code
 		@return graycode return as string
 	*/
 
 	public String binaryToGray(String binarycode)
 	{
 				
-		String graycode=Character.toString(binarycode.charAt(0));
-	
+		String graycode = Character.toString(binarycode.charAt(0));
 		
-		for(int i=0;i<binarycode.length()-1; i++)
+		for(int i = 0; i < binarycode.length() - 1; i++)
 		{
 			
-			if(binarycode.charAt(i)==binarycode.charAt(i+1))
-				graycode=graycode+"0";
+			if (binarycode.charAt(i) == binarycode.charAt(i+1))
+				graycode = graycode + "0";
 			else
-				graycode=graycode+"1";
+				graycode = graycode + "1";
 			
 		}
 	
 		return graycode;
-		
 	}
 
 }
diff --git a/src/test/java/com/conversions/BinaryToGrayTest.java b/src/test/java/com/conversions/BinaryToGrayTest.java
@@ -7,12 +7,11 @@
 public class BinaryToGrayTest
 {
 	
-	
 	@Test
 	public void testBinaryToGray()
 	{
-		BinaryToGray btog=new BinaryToGray();
-		assertEquals("1101",btog.binaryToGray("1001"));
+		BinaryToGray btog = new BinaryToGray();
+		assertEquals("1101", btog.binaryToGray("1001"));
 		assertEquals("11010011101",btog.binaryToGray("10011101001"));
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -3,28 +3,26 @@`
`3`	`3`	`public class BinaryToGray`
`4`	`4`	`{`
`5`	`5`	`/* This method convert the binary number into gray code`
`6`		`- @param binaryno need to convert binary number into gray code`
	`6`	`+ @param binarycode need to convert binary number into gray code`
`7`	`7`	`@return graycode return as string`
`8`	`8`	`*/`
`9`	`9`
`10`	`10`	`public String binaryToGray(String binarycode)`
`11`	`11`	`{`
`12`	`12`
`13`		`- String graycode=Character.toString(binarycode.charAt(0));`
`14`		`-`
	`13`	`+ String graycode = Character.toString(binarycode.charAt(0));`
`15`	`14`
`16`		`- for(int i=0;i<binarycode.length()-1; i++)`
	`15`	`+ for(int i = 0; i < binarycode.length() - 1; i++)`
`17`	`16`	`{`
`18`	`17`
`19`		`- if(binarycode.charAt(i)==binarycode.charAt(i+1))`
`20`		`- graycode=graycode+"0";`
	`18`	`+ if (binarycode.charAt(i) == binarycode.charAt(i+1))`
	`19`	`+ graycode = graycode + "0";`
`21`	`20`	`else`
`22`		`- graycode=graycode+"1";`
	`21`	`+ graycode = graycode + "1";`
`23`	`22`
`24`	`23`	`}`
`25`	`24`
`26`	`25`	`return graycode;`
`27`		`-`
`28`	`26`	`}`
`29`	`27`
`30`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,12 +7,11 @@`
`7`	`7`	`public class BinaryToGrayTest`
`8`	`8`	`{`
`9`	`9`
`10`		`-`
`11`	`10`	`@Test`
`12`	`11`	`public void testBinaryToGray()`
`13`	`12`	`{`
`14`		`- BinaryToGray btog=new BinaryToGray();`
`15`		`- assertEquals("1101",btog.binaryToGray("1001"));`
	`13`	`+ BinaryToGray btog = new BinaryToGray();`
	`14`	`+ assertEquals("1101", btog.binaryToGray("1001"));`
`16`	`15`	`assertEquals("11010011101",btog.binaryToGray("10011101001"));`
`17`	`16`	`}`
`18`	`17`