Removed unused test classes

pajikos · pajikos · commit deb5de3e58a5 · 2018-01-21T23:16:57.000+01:00
diff --git a/spring-security-radius-login/pom.xml b/spring-security-radius-login/pom.xml
@@ -9,7 +9,7 @@
 	<packaging>jar</packaging>
 
 	<name>radius-login</name>
-	<description>Demo project for Spring Boot</description>
+	<description>Spring Security using Radius Login Example</description>
 
 	<parent>
 		<groupId>org.springframework.boot</groupId>
@@ -33,7 +33,6 @@
 			<groupId>org.springframework.boot</groupId>
 			<artifactId>spring-boot-starter-web</artifactId>
 		</dependency>
-
 		<dependency>
 			<groupId>javax.servlet</groupId>
 			<artifactId>jstl</artifactId>
@@ -43,16 +42,6 @@
 			<artifactId>tomcat-embed-jasper</artifactId>
 			<scope>provided</scope>
 		</dependency>
-		<dependency>
-			<groupId>org.springframework.boot</groupId>
-			<artifactId>spring-boot-starter-test</artifactId>
-			<scope>test</scope>
-		</dependency>
-		<dependency>
-			<groupId>org.springframework.security</groupId>
-			<artifactId>spring-security-test</artifactId>
-			<scope>test</scope>
-		</dependency>
 		<dependency>
 			<groupId>com.hynnet</groupId>
 			<artifactId>tinyradius</artifactId>
diff --git a/spring-security-radius-login/src/main/java/com/pavelsklenar/radiuslogin/authentication/NetworkAccessServer.java b/spring-security-radius-login/src/main/java/com/pavelsklenar/radiuslogin/authentication/NetworkAccessServer.java
@@ -10,18 +10,18 @@
 import org.tinyradius.util.RadiusException;
 
 /**
- * Client class is responsible for communication with a remote radius server
+ * NetworkAccessServer (NAS) class is responsible for communication with a remote radius server
  *
  * @author pavel.sklenar
  *
  */
-public class Client {
+public class NetworkAccessServer {
 
     private static final String NAS_IP_ADDRESS = "NAS-IP-Address";
     private static final String NAS_PORT_ID = "NAS-Port-Id";
     private RadiusClient radiusClient;
 
-    public Client(RadiusServer radiusServer) {
+    public NetworkAccessServer(RadiusServer radiusServer) {
     	this.radiusClient = initRadiusClient(radiusServer);
     }
     
diff --git a/spring-security-radius-login/src/main/java/com/pavelsklenar/radiuslogin/authentication/RadiusAuthenticationProvider.java b/spring-security-radius-login/src/main/java/com/pavelsklenar/radiuslogin/authentication/RadiusAuthenticationProvider.java
@@ -27,13 +27,13 @@ public class RadiusAuthenticationProvider implements AuthenticationProvider {
 	@Value("${com.pavelsklenar.radius.server}")
 	private String serverConfigurationToken;
 
-	private List<Client> clients = new ArrayList<>();
+	private List<NetworkAccessServer> clients = new ArrayList<>();
 
 	@PostConstruct
 	public void initServers() {
 		List<RadiusServer> servers = RadiusUtil.parseServerConfigurationToken(serverConfigurationToken);
 		servers.forEach(it -> {
-			clients.add(new Client(it));
+			clients.add(new NetworkAccessServer(it));
 		});
 	}
 
@@ -59,7 +59,7 @@ public Authentication authenticate(Authentication authentication) throws Authent
 		}
 	}
 
-	private RadiusPacket authenticateInternally(Client client, String username, String password) {
+	private RadiusPacket authenticateInternally(NetworkAccessServer client, String username, String password) {
 		logger.info("Calling radius server to authenticate user {}", username);
 		try {
 			return client.authenticate(username, password);
diff --git a/spring-security-radius-login/src/test/java/com/pavelsklenar/radiuslogin/RadiusLoginApplicationTests.java b/spring-security-radius-login/src/test/java/com/pavelsklenar/radiuslogin/RadiusLoginApplicationTests.java

Original file line number	Diff line number	Diff line change
`@@ -10,18 +10,18 @@`
`10`	`10`	`import org.tinyradius.util.RadiusException;`
`11`	`11`
`12`	`12`	`/**`
`13`		`- * Client class is responsible for communication with a remote radius server`
	`13`	`+ * NetworkAccessServer (NAS) class is responsible for communication with a remote radius server`
`14`	`14`	`*`
`15`	`15`	`* @author pavel.sklenar`
`16`	`16`	`*`
`17`	`17`	`*/`
`18`		`-public class Client {`
	`18`	`+public class NetworkAccessServer {`
`19`	`19`
`20`	`20`	`private static final String NAS_IP_ADDRESS = "NAS-IP-Address";`
`21`	`21`	`private static final String NAS_PORT_ID = "NAS-Port-Id";`
`22`	`22`	`private RadiusClient radiusClient;`
`23`	`23`
`24`		`- public Client(RadiusServer radiusServer) {`
	`24`	`+ public NetworkAccessServer(RadiusServer radiusServer) {`
`25`	`25`	`this.radiusClient = initRadiusClient(radiusServer);`
`26`	`26`	`}`
`27`	`27`