Skip to content

Commit 91e9d09

Browse files
houkohouko
committed
p3c
1 parent 3a9d496 commit 91e9d09

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+342
-231
lines changed

‎README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ http://localhost:808/doc.html bootstrap-ui
6666
- 2017-11-02 添加本地运行方式的说明
6767
- 2017-11-02 版本更新到2017.2
6868
- 2017-11-02 spring boot版本更新到1.5.8
69+
- 2017-11-03 添加kotlin环境配置
70+
- 2017-11-03 按照阿里巴巴编程规范插件P3C优化代码
71+
6972

7073

7174
## 贡献者

‎api/src/main/java/info/xiaomo/api/controller/AdminUserController.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import info.xiaomo.api.model.AdminModel;
44
import info.xiaomo.api.service.AdminUserService;
5-
import info.xiaomo.core.constant.CodeConst;
65
import info.xiaomo.core.base.BaseController;
76
import info.xiaomo.core.base.Result;
7+
import info.xiaomo.core.constant.CodeConst;
88
import info.xiaomo.core.exception.UserNotFoundException;
99
import info.xiaomo.core.untils.MD5Util;
1010
import info.xiaomo.core.untils.RandomUtil;
@@ -162,6 +162,7 @@ public Result findById(@PathVariable Long id) {
162162
* @param userName userName
163163
* @return Result
164164
*/
165+
@Override
165166
@ApiOperation(value = "查找用户", notes = "根据传来的用户名查找用户并返回", httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
166167
@RequestMapping(value = "findByName/{userName}", method = RequestMethod.GET)
167168
@ApiImplicitParams({

‎api/src/main/java/info/xiaomo/api/controller/ChangeLogController.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import info.xiaomo.api.model.ChangeLogModel;
44
import info.xiaomo.api.service.ChangeLogService;
5-
import info.xiaomo.core.constant.CodeConst;
65
import info.xiaomo.core.base.BaseController;
76
import info.xiaomo.core.base.Result;
7+
import info.xiaomo.core.constant.CodeConst;
88
import io.swagger.annotations.Api;
99
import io.swagger.annotations.ApiImplicitParam;
1010
import io.swagger.annotations.ApiImplicitParams;
@@ -48,6 +48,7 @@ public ChangeLogController(ChangeLogService service) {
4848
* @param id id
4949
* @return model
5050
*/
51+
@Override
5152
@RequestMapping(value = "findById/{id}",method = RequestMethod.GET)
5253
@ApiOperation(value = "通过id查找", notes = "通过id查找",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
5354
@ApiImplicitParams({
@@ -66,12 +67,13 @@ public Result findById(@PathVariable("id") Long id) {
6667
*
6768
* @return result
6869
*/
70+
@Override
6971
@RequestMapping(value = "findByName/{name}", method = RequestMethod.GET)
7072
@ApiOperation(value = "通过名字查找", notes = "通过名字查找",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
7173
@ApiImplicitParams({
7274
@ApiImplicitParam(name = "name", value = "更新日志内容", required = true, dataType = "String", paramType = "path")
7375
})
74-
public Result findByName( @PathVariable("name") String name) {
76+
public Result findByName(@PathVariable("name") String name) {
7577
ChangeLogModel model = service.findByName(name);
7678
if (model == null) {
7779
return new Result(CodeConst.NULL_DATA.getResultCode(), CodeConst.NULL_DATA.getMessage());
@@ -139,6 +141,7 @@ public Result<Boolean> delByIds(@PathVariable List ids) {
139141
*
140142
* @return 分页
141143
*/
144+
@Override
142145
@RequestMapping(value = "findAll", method = RequestMethod.GET)
143146
@ApiOperation(value = "分页查询更新日志", notes = "分页查询更新日志",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
144147
public Result findAll() {

‎api/src/main/java/info/xiaomo/api/controller/LinkController.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import info.xiaomo.api.model.LinkModel;
44
import info.xiaomo.api.service.LinkService;
5-
import info.xiaomo.core.constant.CodeConst;
65
import info.xiaomo.core.base.BaseController;
76
import info.xiaomo.core.base.Result;
7+
import info.xiaomo.core.constant.CodeConst;
88
import io.swagger.annotations.Api;
99
import io.swagger.annotations.ApiImplicitParam;
1010
import io.swagger.annotations.ApiImplicitParams;
@@ -67,6 +67,7 @@ public Result findLinkById(@PathVariable("id") Long id) {
6767
* @param name name
6868
* @return model
6969
*/
70+
@Override
7071
@RequestMapping(value = "findByName/{name}",method = RequestMethod.GET)
7172
@ApiOperation(value = "根据名字查找", notes = "根据名字查找",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
7273
@ApiImplicitParams({
@@ -141,6 +142,7 @@ public Result<Boolean> delByIds(@PathVariable List ids) {
141142
*
142143
* @return 所有
143144
*/
145+
@Override
144146
@RequestMapping(value = "findAll",method = RequestMethod.GET)
145147
@ApiOperation(value = "返回所有数据", notes = "返回所有数据",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
146148
public Result findAll() {

‎api/src/main/java/info/xiaomo/api/controller/WebSetController.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import info.xiaomo.api.model.SystemSetModel;
44
import info.xiaomo.api.service.WebSetService;
5-
import info.xiaomo.core.constant.CodeConst;
65
import info.xiaomo.core.base.BaseController;
76
import info.xiaomo.core.base.Result;
7+
import info.xiaomo.core.constant.CodeConst;
88
import io.swagger.annotations.Api;
99
import io.swagger.annotations.ApiOperation;
1010
import org.springframework.beans.factory.annotation.Autowired;
@@ -45,11 +45,12 @@ public WebSetController(WebSetService service) {
4545
*
4646
* @return list
4747
*/
48+
@Override
4849
@ApiOperation(value = "查找所有", notes = "查找所有",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
4950
@RequestMapping(value = "findAll", method = RequestMethod.GET)
5051
public Result findAll() {
5152
List<SystemSetModel> list = service.findAll();
52-
if (list.isEmpty() || list.size() == 0) {
53+
if (list.isEmpty()) {
5354
return new Result(CodeConst.NULL_DATA.getResultCode(), CodeConst.NULL_DATA.getMessage());
5455
}
5556
return new Result(list);

‎api/src/main/java/info/xiaomo/api/controller/WorksController.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import info.xiaomo.api.model.WorksModel;
44
import info.xiaomo.api.service.WorksService;
5-
import info.xiaomo.core.constant.CodeConst;
65
import info.xiaomo.core.base.BaseController;
76
import info.xiaomo.core.base.Result;
7+
import info.xiaomo.core.constant.CodeConst;
88
import io.swagger.annotations.Api;
99
import io.swagger.annotations.ApiImplicitParam;
1010
import io.swagger.annotations.ApiImplicitParams;
@@ -45,6 +45,7 @@ public WorksController(WorksService service) {
4545
}
4646

4747

48+
@Override
4849
@RequestMapping(value = "/findById/{id}",method = RequestMethod.GET)
4950
@ApiOperation(value = "根据id查找作品", notes = "根据id查找作品",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
5051
@ApiImplicitParams({
@@ -58,6 +59,7 @@ public Result findById(@PathVariable Long id) {
5859
return new Result<>(model);
5960
}
6061

62+
@Override
6163
@RequestMapping(value = "/findAll",method = RequestMethod.GET)
6264
@ApiOperation(value = "查找所有", notes = "查找所有",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
6365
public Result findAll() {
@@ -81,6 +83,7 @@ public Result<Page> findAll(@PathVariable int start, @PathVariable int pageSize)
8183
}
8284

8385

86+
@Override
8487
@RequestMapping(value = "/findByName/{name}",method = RequestMethod.GET)
8588
@ApiOperation(value = "根据名字查找作品", notes = "根据名字查找作品",httpMethod = "GET", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
8689
@ApiImplicitParams({

‎core/src/main/java/info/xiaomo/core/base/AuthOperate.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import java.util.Date;
66

77
/**
8-
* author 小莫 (https://xiaomo.info) (https://github.com/xiaomoinfo)
8+
* @author : xiaomo (https://xiaomo.info) (https://github.com/xiaomoinfo)
99
* @version : 2017/1/13 9:51
1010
*/
1111
public interface AuthOperate {

‎core/src/main/java/info/xiaomo/core/base/BaseController.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.util.List;
1111

1212
/**
13-
* author 小莫 (https://xiaomo.info) (https://github.com/xiaomoinfo)
13+
* @author : xiaomo (https://xiaomo.info) (https://github.com/xiaomoinfo)
1414
* @version : 2017/1/11 16:41
1515
*/
1616
@RestController

‎core/src/main/java/info/xiaomo/core/base/BaseDao.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import org.springframework.stereotype.Repository;
55

66
/**
7-
* author 小莫 (https://xiaomo.info) (https://github.com/xiaomoinfo)
7+
* @author : xiaomo (https://xiaomo.info) (https://github.com/xiaomoinfo)
88
* @version : 2017/1/13 11:23
99
*/
1010
@Repository

‎core/src/main/java/info/xiaomo/core/base/BaseService.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.util.List;
77

88
/**
9-
* author 小莫 (https://xiaomo.info) (https://github.com/xiaomoinfo)
9+
* @author : xiaomo (https://xiaomo.info) (https://github.com/xiaomoinfo)
1010
* @version : 2017/1/11 16:42
1111
*/
1212
@Service

0 commit comments

Comments
 (0)