Polishing

jhoeller · jhoeller · commit 52e5b4a6ffb1 · 2016-05-03T18:55:39.000+02:00
diff --git a/spring-web/src/main/java/org/springframework/remoting/httpinvoker/HttpInvokerServiceExporter.java b/spring-web/src/main/java/org/springframework/remoting/httpinvoker/HttpInvokerServiceExporter.java
@@ -202,24 +202,27 @@ protected OutputStream decorateOutputStream(
 		return os;
 	}
 
+
 	/**
-	 * Decorate an OutputStream to guard against {@code flush()} calls, which
-	 * are turned into no-ops.
+	 * Decorate an {@code OutputStream} to guard against {@code flush()} calls,
+	 * which are turned into no-ops.
+	 *
 	 * <p>Because {@link ObjectOutputStream#close()} will in fact flush/drain
 	 * the underlying stream twice, this {@link FilterOutputStream} will
 	 * guard against individual flush calls. Multiple flush calls can lead
 	 * to performance issues, since writes aren't gathered as they should be.
 	 *
 	 * @see <a href="https://jira.spring.io/browse/SPR-14040">SPR-14040</a>
 	 */
-	class FlushGuardedOutputStream extends FilterOutputStream {
+	private static class FlushGuardedOutputStream extends FilterOutputStream {
+
 		public FlushGuardedOutputStream(OutputStream out) {
 			super(out);
 		}
 
 		@Override
 		public void flush() throws IOException {
-			// Do nothing
+			// Do nothing on flush
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -202,24 +202,27 @@ protected OutputStream decorateOutputStream(`
`202`	`202`	`return os;`
`203`	`203`	`}`
`204`	`204`
	`205`	`+`
`205`	`206`	`/**`
`206`		`- * Decorate an OutputStream to guard against {@code flush()} calls, which`
`207`		`- * are turned into no-ops.`
	`207`	`+ * Decorate an {@code OutputStream} to guard against {@code flush()} calls,`
	`208`	`+ * which are turned into no-ops.`
	`209`	`+ *`
`208`	`210`	`* <p>Because {@link ObjectOutputStream#close()} will in fact flush/drain`
`209`	`211`	`* the underlying stream twice, this {@link FilterOutputStream} will`
`210`	`212`	`* guard against individual flush calls. Multiple flush calls can lead`
`211`	`213`	`* to performance issues, since writes aren't gathered as they should be.`
`212`	`214`	`*`
`213`	`215`	`* @see <a href="https://jira.spring.io/browse/SPR-14040">SPR-14040</a>`
`214`	`216`	`*/`
`215`		`- class FlushGuardedOutputStream extends FilterOutputStream {`
	`217`	`+ private static class FlushGuardedOutputStream extends FilterOutputStream {`
	`218`	`+`
`216`	`219`	`public FlushGuardedOutputStream(OutputStream out) {`
`217`	`220`	`super(out);`
`218`	`221`	`}`
`219`	`222`
`220`	`223`	`@Override`
`221`	`224`	`public void flush() throws IOException {`
`222`		`- // Do nothing`
	`225`	`+ // Do nothing on flush`
`223`	`226`	`}`
`224`	`227`	`}`
`225`	`228`