add check on null objects

isabiq · isabiq · commit c572fe885ed8 · 2017-07-29T12:16:19.000+01:00
diff --git a/cqrs/src/main/java/com/iluwatar/cqrs/commandes/CommandServiceImpl.java b/cqrs/src/main/java/com/iluwatar/cqrs/commandes/CommandServiceImpl.java
@@ -23,6 +23,9 @@ private Author getAuthorByUsername(String username) {
       query.setParameter("username", username);
       author = (Author) query.uniqueResult();
     }
+    if (author == null) {
+      throw new NullPointerException("Author " + username + " doesn't exist!");
+    }
     return author;
   }
 
@@ -33,6 +36,9 @@ private Book getBookByTitle(String title) {
       query.setParameter("title", title);
       book = (Book) query.uniqueResult();
     }
+    if (book == null) {
+      throw new NullPointerException("Book " + title + " doesn't exist!");
+    }
     return book;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,9 @@ private Author getAuthorByUsername(String username) {`
`23`	`23`	`query.setParameter("username", username);`
`24`	`24`	`author = (Author) query.uniqueResult();`
`25`	`25`	`}`
	`26`	`+ if (author == null) {`
	`27`	`+ throw new NullPointerException("Author " + username + " doesn't exist!");`
	`28`	`+ }`
`26`	`29`	`return author;`
`27`	`30`	`}`
`28`	`31`
`@@ -33,6 +36,9 @@ private Book getBookByTitle(String title) {`
`33`	`36`	`query.setParameter("title", title);`
`34`	`37`	`book = (Book) query.uniqueResult();`
`35`	`38`	`}`
	`39`	`+ if (book == null) {`
	`40`	`+ throw new NullPointerException("Book " + title + " doesn't exist!");`
	`41`	`+ }`
`36`	`42`	`return book;`
`37`	`43`	`}`
`38`	`44`