Fixing squid:S1854 - Dead stores should be removed

kirill-vlasov · kirill-vlasov · commit 6e496e7c8682 · 2015-12-23T13:41:38.000+05:00
diff --git a/caching/src/main/java/com/iluwatar/caching/App.java b/caching/src/main/java/com/iluwatar/caching/App.java
@@ -65,8 +65,8 @@ public void useReadAndWriteThroughStrategy() {
 
     AppManager.save(userAccount1);
     System.out.println(AppManager.printCacheContent());
-    userAccount1 = AppManager.find("001");
-    userAccount1 = AppManager.find("001");
+    AppManager.find("001");
+    AppManager.find("001");
   }
 
   /**
@@ -80,15 +80,15 @@ public void useReadThroughAndWriteAroundStrategy() {
 
     AppManager.save(userAccount2);
     System.out.println(AppManager.printCacheContent());
-    userAccount2 = AppManager.find("002");
+    AppManager.find("002");
     System.out.println(AppManager.printCacheContent());
     userAccount2 = AppManager.find("002");
     userAccount2.setUserName("Jane G.");
     AppManager.save(userAccount2);
     System.out.println(AppManager.printCacheContent());
-    userAccount2 = AppManager.find("002");
+    AppManager.find("002");
     System.out.println(AppManager.printCacheContent());
-    userAccount2 = AppManager.find("002");
+    AppManager.find("002");
   }
 
   /**
@@ -106,12 +106,12 @@ public void useReadThroughAndWriteBehindStrategy() {
     AppManager.save(userAccount4);
     AppManager.save(userAccount5);
     System.out.println(AppManager.printCacheContent());
-    userAccount3 = AppManager.find("003");
+    AppManager.find("003");
     System.out.println(AppManager.printCacheContent());
     UserAccount userAccount6 = new UserAccount("006", "Yasha", "She is an only child.");
     AppManager.save(userAccount6);
     System.out.println(AppManager.printCacheContent());
-    userAccount4 = AppManager.find("004");
+    AppManager.find("004");
     System.out.println(AppManager.printCacheContent());
   }
 }
diff --git a/tolerant-reader/src/main/java/com/iluwatar/tolerantreader/RainbowFishSerializer.java b/tolerant-reader/src/main/java/com/iluwatar/tolerantreader/RainbowFishSerializer.java
@@ -70,10 +70,9 @@ public static void writeV2(RainbowFishV2 rainbowFish, String filename) throws IO
    * @throws ClassNotFoundException
    */
   public static RainbowFish readV1(String filename) throws IOException, ClassNotFoundException {
-    Map<String, String> map = null;
     FileInputStream fileIn = new FileInputStream(filename);
     ObjectInputStream objIn = new ObjectInputStream(fileIn);
-    map = (Map<String, String>) objIn.readObject();
+    Map<String, String> map = (Map<String, String>) objIn.readObject();
     objIn.close();
     fileIn.close();
     return new RainbowFish(map.get("name"), Integer.parseInt(map.get("age")), Integer.parseInt(map
