kubernetes-client#1802 Check if server is available from kubeconfig.

cbuschka · cbuschka · commit c983fc336c11 · 2021-11-14T20:42:32.000+01:00
diff --git a/util/src/main/java/io/kubernetes/client/util/ClientBuilder.java b/util/src/main/java/io/kubernetes/client/util/ClientBuilder.java
@@ -277,6 +277,9 @@ public static ClientBuilder kubeconfig(KubeConfig config) throws IOException {
     final ClientBuilder builder = new ClientBuilder();
 
     String server = config.getServer();
+    if (server == null) {
+        throw new IllegalArgumentException("No server in kubeconfig");
+    }
     if (!server.contains("://")) {
       if (server.contains(":443")) {
         server = "https://" + server;
diff --git a/util/src/test/java/io/kubernetes/client/util/ClientBuilderTest.java b/util/src/test/java/io/kubernetes/client/util/ClientBuilderTest.java
@@ -18,6 +18,7 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.core.Is.is;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThrows;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 
@@ -31,6 +32,7 @@
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Paths;
+
 import org.junit.Test;
 
 /** Tests for the ConfigBuilder helper class */
@@ -299,4 +301,13 @@ public void testSettingPassphraseForKubeConfigShouldWork() throws IOException {
         ((ClientCertificateAuthentication) receivingAuthn.getDelegateAuthentication())
             .getPassphrase());
   }
+
+  @Test
+  public void testDetectsServerNotSet() {
+    assertThrows("No server in kubeconfig", IllegalArgumentException.class, () -> {
+      KubeConfig kubeConfigWithoutServer = mock(KubeConfig.class);
+
+      ClientBuilder.kubeconfig(kubeConfigWithoutServer);
+    });
+  }
 }
