all: Only depend on evaluation of enumerated subprojects

ejona86 · ejona86 · commit 8a9aa414160f · 2021-04-19T14:18:54.000-07:00
Back in 10fb206 when this for loop was added, we didn't have the subprojects list. That was added in 9bd7bab, but I failed to update one reference to rootProject. So all has had an evaluation dependency on all projects, even though it only needs a subset. This should have little impact, but would prevent weird scenarios like an issue in :grpc-gae-interop-testing-jdk8 preventing :all-all from being loaded. Not to say things wouldn't still fail to load, but that this bug could distract from the real problem. I noticed this during grpc#8049.
diff --git a/all/build.gradle b/all/build.gradle
@@ -24,12 +24,13 @@ def subprojects = [
     project(':grpc-xds'),
 ]
 
-for (subproject in rootProject.subprojects) {
+for (subproject in subprojects) {
     if (subproject == project) {
         continue
     }
     evaluationDependsOn(subproject.path)
 }
+evaluationDependsOn(':grpc-interop-testing')
 
 dependencies {
     api subprojects.minus([project(':grpc-protobuf-lite')])

Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,13 @@ def subprojects = [`
`24`	`24`	`project(':grpc-xds'),`
`25`	`25`	`]`
`26`	`26`
`27`		`-for (subproject in rootProject.subprojects) {`
	`27`	`+for (subproject in subprojects) {`
`28`	`28`	`if (subproject == project) {`
`29`	`29`	`continue`
`30`	`30`	`}`
`31`	`31`	`evaluationDependsOn(subproject.path)`
`32`	`32`	`}`
	`33`	`+evaluationDependsOn(':grpc-interop-testing')`
`33`	`34`
`34`	`35`	`dependencies {`
`35`	`36`	`api subprojects.minus([project(':grpc-protobuf-lite')])`