Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chromiumembedded/java-cef
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: JScheiterbauer/java-cef
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 30, 2024

  1. We had problems on windows 32bit systems using the reparenting feature. 

    Sometimes (timing issue) the JCEF native code in CefBrowser_N.cpp uses a wrong parent window handle.
With this change the problem was gone, also see #321.

Reproduction:
The problem can happen on physical machines too but happen much more often when connected to remote machines (e.g. Citrix sessions, Remote Desktop, VMWares,...).
- Start detailed MainFrame
- Menu -> Tests -> Reparent
- Press the "Reparent </>" Button as fast as you can (Space bar helps)
The bug then sometimes happens on the 5th try or you have to do this for a minute or so.
    @JScheiterbauer
    JScheiterbauer committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9eca63f View commit details
    Browse the repository at this point in the history
Loading