Major Issue in 4.4, FROM Keyword is not Mandatory #1514

Activity

1. manticore-projects commented on Apr 19, 2022

   

   manticore-projects

   on Apr 19, 2022

   Last edited by manticore-projects

   Contributor

   More actions

   Greetings.

   Your statement matches SELECT expression alias and is valid Standard SQL (although not Oracle compliant).

   If you want to validate against the Oracle Dialect, you may look onto the Validation Framework (part of JSQLParser).
2. bala28 commented on Apr 19, 2022

   

   bala28

   on Apr 19, 2022

   Author

   More actions

   thanks @manticore-projects for reply.

   1. is this new feature in 4.4 ? if not , why it is working in 4.3 ?
   2. Secondly , i tried with validation framework , but the validation errors is 0 , do i miss something below ?

    Validation validation = new Validation(Arrays.asList(DatabaseType.ORACLE), "SELECT SYSDATE  DUAL WHERE 1=1");
     List<ValidationError> errors = validation.validate();
   

   from below article , i can see some databases support "SELECT without FROM"

   https://modern-sql.com/use-case/select-without-from ,

   In that case , my suggestion will be adding database type during parse in CCJSqlParserUtil.parse(sqlStatement);
3. manticore-projects commented on Apr 19, 2022

   

   manticore-projects

   on Apr 19, 2022

   Contributor

   More actions

   thanks @manticore-projects for reply.

   1. is this new feature in 4.4 ? if not , why it is working in 4.3 ?
   

   Yes, prior 4.4 JSQLParser supported only SELECT SimpleExpression, which has been improved now into SELECT Expression.

   2. Secondly , i tried with validation framework , but the validation errors is 0 , do i miss something below ?
   

    Validation validation = new Validation(Arrays.asList(DatabaseType.ORACLE), "SELECT SYSDATE  DUAL WHERE 1=1");
     List<ValidationError> errors = validation.validate();
   

   I can not say much about the Validation Framework, because I do not maintain or use it.
   Although I do know that it has holes and did not fully keep up with the latest JSQLParser developments.

   So if you want to use it, then rather understand it as a template, which you may want to add to in order to validate your particular concerns.

   from below article , i can see some databases support "SELECT without FROM"

   https://modern-sql.com/use-case/select-without-from ,

   In that case , my suggestion will be adding database type during parse in CCJSqlParserUtil.parse(sqlStatement);

   Your consideration is correct and in fact I have had similar thoughts in the past.
   However:

   a) JSQLParser's main objective is to parse RDBMS agnostic and to retrieve the AST from any SQL
   b) We would have to maintain a Grammar for each dialect, while JavaCC does not support any include directive. So we would need to engage a template-engine for the Grammars -- a lot of work not justified by any added value

   Your provided statement is parsed correctly.
   You do not want to parse, but to validate. That's what the validation framework is for. If you find a short coming in the validation framework, then best thing was to submit a PR (because interest in that validation framework seems to be low).
4. bala28 commented on Apr 19, 2022

   

   bala28

   on Apr 19, 2022

   Author

   More actions

   thanks @manticore-projects , could you please update the release notes for 4.4, so that it will be clear ?.

   i feel like the validation framework should be re-worked, just fixing a simple case wont work , thats how i feel , i may be wrong also.
   i will add the validation from my side . please close the ticket , once the release notes is updated.
5. manticore-projects

   closed this as completedon Apr 22, 2022
6. wumpz commented on Apr 26, 2022

   

   wumpz

   on Apr 26, 2022

   Member

   More actions

   I check with version 4.0, 4.1, 4.3 and could successfully parse your statement SELECT SYSDATE DUAL. So what do you mean by ""FROM" keyword validation is working in 4.3"?