fix: Remove tests for (), since ParenthesedExpressionList will catch those too

manticore-projects · manticore-projects · commit 905ef6512d59 · 2023-05-03T20:14:29.000+07:00
diff --git a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
@@ -2761,8 +2761,6 @@ GroupByElement GroupByColumnReferences():
 {
     <K_GROUP> <K_BY>
     (
-        LOOKAHEAD(2) "(" token=")" { groupBy.setGroupByExpressions( new ParenthesedExpressionList() ); }
-        |
         LOOKAHEAD(2) (
             <K_GROUPING> <K_SETS> "("
             list = GroupingSet() { groupBy.addGroupingSet(list); }
@@ -2792,8 +2790,6 @@ ExpressionList GroupingSet():
 }
 {
     (
-        LOOKAHEAD(2) "(" token=")" { list = new ParenthesedExpressionList(); }
-        |
         LOOKAHEAD(2) list = ParenthesedExpressionList()
         |
         expression = SimpleExpression() { list = new ExpressionList(expression); }
@@ -4666,8 +4662,6 @@ Execute Execute(): {
     funcName=RelObjectNameList() { execute.setName(funcName); }
 
     (
-//        ( "(" token=")" { execute.setExprList( new ParenthesedExpressionList()); })
-//        |
         expressionList=ExpressionList() { execute.setExprList(expressionList); }
     )?
 
diff --git a/src/test/resources/net/sf/jsqlparser/statement/select/oracle-tests/function06.sql b/src/test/resources/net/sf/jsqlparser/statement/select/oracle-tests/function06.sql
@@ -9,4 +9,5 @@
 ---
 call dbms_scheduler.auto_purge (  )
 
---@FAILURE: Encountered unexpected token: ")" ")" recorded first on Aug 3, 2021, 7:20:08 AM
+--@FAILURE: Encountered unexpected token: ")" ")" recorded first on Aug 3, 2021, 7:20:08 AM
+--@SUCCESSFULLY_PARSED_AND_DEPARSED first on 3 May 2023, 20:10:15

Original file line number	Diff line number	Diff line change
`@@ -2761,8 +2761,6 @@ GroupByElement GroupByColumnReferences():`
`2761`	`2761`	`{`
`2762`	`2762`	`<K_GROUP> <K_BY>`
`2763`	`2763`	`(`
`2764`		`- LOOKAHEAD(2) "(" token=")" { groupBy.setGroupByExpressions( new ParenthesedExpressionList() ); }`
`2765`		`- \|`
`2766`	`2764`	`LOOKAHEAD(2) (`
`2767`	`2765`	`<K_GROUPING> <K_SETS> "("`
`2768`	`2766`	`list = GroupingSet() { groupBy.addGroupingSet(list); }`
`@@ -2792,8 +2790,6 @@ ExpressionList GroupingSet():`
`2792`	`2790`	`}`
`2793`	`2791`	`{`
`2794`	`2792`	`(`
`2795`		`- LOOKAHEAD(2) "(" token=")" { list = new ParenthesedExpressionList(); }`
`2796`		`- \|`
`2797`	`2793`	`LOOKAHEAD(2) list = ParenthesedExpressionList()`
`2798`	`2794`	`\|`
`2799`	`2795`	`expression = SimpleExpression() { list = new ExpressionList(expression); }`
`@@ -4666,8 +4662,6 @@ Execute Execute(): {`
`4666`	`4662`	`funcName=RelObjectNameList() { execute.setName(funcName); }`
`4667`	`4663`
`4668`	`4664`	`(`
`4669`		`-// ( "(" token=")" { execute.setExprList( new ParenthesedExpressionList()); })`
`4670`		`-// \|`
`4671`	`4665`	`expressionList=ExpressionList() { execute.setExprList(expressionList); }`
`4672`	`4666`	`)?`
`4673`	`4667`