Improves/fixes error handling in xmlrpc server

sudorandom · sudorandom · commit a3148c62ff9c · 2015-04-26T22:56:24.000-05:00
diff --git a/SoftLayer/testing/xmlrpc.py b/SoftLayer/testing/xmlrpc.py
@@ -55,20 +55,20 @@ def do_POST(self):
 
             response_body = utils.xmlrpc_client.dumps((response,),
                                                       allow_none=True,
-                                                      methodresponse=1)
+                                                      methodresponse=True)
 
             self.send_response(200)
             self.send_header("Content-type", "application/xml")
             self.end_headers()
             self.wfile.write(response_body.encode('utf-8'))
 
         except SoftLayer.SoftLayerAPIError as ex:
-            self.send_response(ex.faultCode or 500)
+            self.send_response(200)
             self.end_headers()
             response = utils.xmlrpc_client.Fault(ex.faultCode, str(ex.reason))
-            response_body = utils.xmlrpc_client.dumps((response,),
+            response_body = utils.xmlrpc_client.dumps(response,
                                                       allow_none=True,
-                                                      methodresponse=1)
+                                                      methodresponse=True)
             self.wfile.write(response_body.encode('utf-8'))
         except Exception as ex:
             self.send_response(500)
