Improve logging of failed assert_called_with assertions

sudorandom · sudorandom · commit 3d145de44828 · 2014-11-13T09:44:13.000-06:00
diff --git a/SoftLayer/testing/__init__.py b/SoftLayer/testing/__init__.py
@@ -148,15 +148,16 @@ def run_command(self,
 def call_has_props(call, props):
     """Check if a call has matching properties of a given props dictionary."""
 
-    for prop, value in props.items():
-        call_value = getattr(call, prop)
-        if call_value != value:
-            logging.info('%s::%s property mismatch(%s): %r != %r',
-                         call.service,
-                         call.method,
-                         prop,
-                         value,
-                         call_value)
+    for prop, expected_value in props.items():
+        actual_value = getattr(call, prop)
+        if actual_value != expected_value:
+            logging.info(
+                '%s::%s property mismatch, %s: expected=%r; actual=%r',
+                call.service,
+                call.method,
+                prop,
+                expected_value,
+                actual_value)
             return False
 
     return True
