Merge pull request php-pm#512 from jkrzefski/patch-1

acasademont · web-flow · commit 84ab48092c47 · 2020-08-10T18:07:05.000+02:00
Move register_shutdown_function from constructor to run method
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
@@ -247,8 +247,6 @@ public function __construct(OutputInterface $output, $port = 8080, $host = '127.
 
         $this->slaveCount = $slaveCount;
         $this->slaves = new SlavePool(); // create early, used during shutdown
-
-        register_shutdown_function([$this, 'shutdown']);
     }
 
     /**
@@ -510,6 +508,7 @@ public function setReloadTimeout($reloadTimeout)
     public function run()
     {
         Debug::enable();
+        register_shutdown_function([$this, 'shutdown']);
 
         // make whatever is necessary to disable all stuff that could buffer output
         ini_set('zlib.output_compression', 0);

Original file line number	Diff line number	Diff line change
`@@ -247,8 +247,6 @@ public function __construct(OutputInterface $output, $port = 8080, $host = '127.`
`247`	`247`
`248`	`248`	`$this->slaveCount = $slaveCount;`
`249`	`249`	`$this->slaves = new SlavePool(); // create early, used during shutdown`
`250`		`-`
`251`		`- register_shutdown_function([$this, 'shutdown']);`
`252`	`250`	`}`
`253`	`251`
`254`	`252`	`/**`
`@@ -510,6 +508,7 @@ public function setReloadTimeout($reloadTimeout)`
`510`	`508`	`public function run()`
`511`	`509`	`{`
`512`	`510`	`Debug::enable();`
	`511`	`+ register_shutdown_function([$this, 'shutdown']);`
`513`	`512`
`514`	`513`	`// make whatever is necessary to disable all stuff that could buffer output`
`515`	`514`	`ini_set('zlib.output_compression', 0);`