Add better logging for disabled PCNTL extensions (php-pm#371)

fisk · andig · commit 21e8a0a68f02 · 2018-04-11T14:08:23.000+02:00
diff --git a/bin/ppm b/bin/ppm
@@ -18,8 +18,17 @@ if ((!$loader = includeIfExists(__DIR__.'/../vendor/autoload.php')) && (!$loader
     );
 }
 
+if (!PHPPM\pcntl_installed()) {
+    die(
+        sprintf(
+            'PCNTL is not enabled in the PHP installation at %s. See: http://php.net/manual/en/pcntl.installation.php',
+            PHP_BINARY
+        )
+    );
+}
+
 if (!PHPPM\pcntl_enabled()) {
-    die('Some of required pcntl functions are disabled. Check `disable_functions` setting in `php.ini`.');
+    die('Some required PCNTL functions are disabled. Check `disabled_functions` in `php.ini`.');
 }
 
 use Symfony\Component\Console\Application;
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
@@ -1095,9 +1095,20 @@ protected function newSlaveInstance($port)
 require_once file_exists($dir . '/vendor/autoload.php')
     ? $dir . '/vendor/autoload.php'
     : $dir . '/../../autoload.php';
+    
+if (!pcntl_installed()) {
+    error_log(
+        sprintf(
+            'PCNTL is not enabled in the PHP installation at %s. See: http://php.net/manual/en/pcntl.installation.php',
+            PHP_BINARY
+        )
+    );
+    exit();
+}
 
 if (!pcntl_enabled()) {
-    throw new \RuntimeException('Some of required pcntl functions are disabled. Check `disable_functions` setting in `php.ini`.');
+    error_log('Some required PCNTL functions are disabled. Check `disabled_functions` in `php.ini`.');
+    exit();
 }
 
 //global for all global functions
diff --git a/src/functions.php b/src/functions.php
@@ -30,7 +30,17 @@ function console_log($expression, $_ = null)
 }
 
 /**
- * Checks that all required pcntl functions are available, so not fatal errors would be cause in runtime
+ * Checks that PCNTL is actually enabled in this installation.
+ *
+ * @return bool
+ */
+function pcntl_installed()
+{
+    return function_exists('pcntl_signal');
+}
+
+/**
+ * Makes sure required PCNTL functions aren't included in disable_functions.
  *
  * @return bool
  */
