Minor code cleanup (php-pm#353)

szepeviktor · andig · commit 1ae68b2db22b · 2018-02-05T16:23:06.000+01:00
* Use phpstan level 4
* Fix $errorLogger's types
* Fix $phpCgiExecutable's default value
diff --git a/.travis.yml b/.travis.yml
@@ -15,7 +15,7 @@ install:
 
 script:
   # Static analyzer check
-  - if [ $TRAVIS_PHP_VERSION = '7.1' ]; then composer require "phpstan/phpstan:^0.9" && ./vendor/bin/phpstan analyze -c .phpstan.neon --level=2 --no-progress src;fi
+  - if [ $TRAVIS_PHP_VERSION = '7.1' ]; then composer require "phpstan/phpstan:^0.9" && ./vendor/bin/phpstan analyze -c .phpstan.neon --level=4 --no-progress src;fi
   # Check the code style
   - if [ $TRAVIS_PHP_VERSION = '7.1' ]; then IFS=$'\n'; COMMIT_SCA_FILES=($(git diff --name-only --diff-filter=ACMRTUXB "${TRAVIS_COMMIT_RANGE}")); unset IFS; fi
   - if [ $TRAVIS_PHP_VERSION = '7.1' ]; then composer require "friendsofphp/php-cs-fixer:^2.8" && ./vendor/bin/php-cs-fixer fix --config=.php_cs.php -v --dry-run --stop-on-violation --using-cache=no --path-mode=intersection -- "${COMMIT_SCA_FILES[@]}";fi
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
@@ -140,7 +140,7 @@ class ProcessManager
      *
      * @var string
      */
-    protected $phpCgiExecutable = false;
+    protected $phpCgiExecutable = '';
 
     /**
      * @var null|int
diff --git a/src/ProcessSlave.php b/src/ProcessSlave.php
@@ -84,7 +84,7 @@ class ProcessSlave
     protected $inShutdown = false;
 
     /**
-     * @var BufferingLogger
+     * @var BufferingLogger|\Symfony\Component\Debug\BufferingLogger
      */
     protected $errorLogger;
 

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ class ProcessManager`
`140`	`140`	`*`
`141`	`141`	`* @var string`
`142`	`142`	`*/`
`143`		`- protected $phpCgiExecutable = false;`
	`143`	`+ protected $phpCgiExecutable = '';`
`144`	`144`
`145`	`145`	`/**`
`146`	`146`	`* @var null\|int`